Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-13 Init commit for CW Row display custom DS field #62

Merged
merged 31 commits into from
Mar 7, 2016

Conversation

bimsonz
Copy link
Contributor

@bimsonz bimsonz commented Feb 29, 2016

Feature https://jira.comicrelief.com/browse/PLAT-13

Changes proposed in this pull request

  • Custom ds field base class
  • Load current row block
  • Get referenced blocks for display
  • Switch-able row displays based on select list
  • Prevent any warnings

Deployment instructions

  • No manual actions required for deployment

Moving work from old branch to new branch, making init
commit to create PR
@bimsonz bimsonz self-assigned this Feb 29, 2016
Drupal 8 is going to be filled with lots of these time wasting
learning curves i reckon :(
Loading the the current block and reference field to grab referenced
entities
getReferencedBlocks
getRowEntity
Also added catch for missing config
getBlockViewModes
buildRenderedBlocks
Looks to work but needs some testing and clean up
Updated Row block display modes to remove content block reference
field and add custom DsField to display. This field controls how
each block within that row is rendered.
@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 4, 2016

@gusliedke Ive added two new view modes, s + m (medium portrait) and m + s, all you need to do is create the image style how you want it and configure the rest of the CW - MP view mode.

Ive not added any default content yet so feel free to do that...

@Saphyel
Copy link
Contributor

Saphyel commented Mar 7, 2016

@bimsonz could you write a documentation about the new views mode & fields, etc..?

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 7, 2016

@Saphyel Added readme.md, let me know if you want more detail...

@Saphyel
Copy link
Contributor

Saphyel commented Mar 7, 2016

I don't like the "@todo" xD but otherwise looks fine

Saphyel added a commit that referenced this pull request Mar 7, 2016
PLAT-13 Init commit for CW Row display custom DS field
@Saphyel Saphyel merged commit 2629af1 into develop Mar 7, 2016
@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 7, 2016

@Saphyel thanks dude, we are gunna pick up the node reference block at a later date if necessary, hopefully wont need to :)

@bimsonz bimsonz deleted the feature/PLAT-13_content_wall branch March 7, 2016 14:44
@Saphyel
Copy link
Contributor

Saphyel commented Mar 7, 2016

@bimsonz ahh ok,i hope the same! ^^

@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants