This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
PLAT-489 fullwidth mobile button option #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passed QA |
AndyEPhipps
deleted the
feature/PLAT-489_fullwidth_mobile_button_option
branch
bimsonz
changed the title
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.comicrelief.com/browse/PLAT-489#comment-74307
Notes:
2 sibling buttons (that sit side-by-side, wrapped by a P tag) will need to remain full-width SM. This is due to display inline-block limitations, and display block will naturally go full-width without a fixed width supplied.
As we can't target them in CSS alone, we'd just need to add the new 'btn--full-width' class to them too in order to make everything groovy again, or else this happens on the larger side of SM breakpoint
https://jira.comicrelief.com/secure/attachment/33323/Screen%20Shot%202016-11-11%20at%2012.17.12.png