Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-549 Removing panelizer #637

Merged
merged 8 commits into from
Dec 16, 2016
Merged

PLAT-549 Removing panelizer #637

merged 8 commits into from
Dec 16, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Nov 17, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-549

  • remove cr custom layout

Manual steps

panels_ipe, panels, quick edits & contextual links

@bimsonz
Copy link
Contributor

bimsonz commented Dec 7, 2016

@Saphyel I've done some investigation around https://jira.comicrelief.com/browse/RND-514 and https://jira.comicrelief.com/browse/RND-513 and have discovered that its panelizer that's creating this duplicate tag... that bumps the priority of this higher.

I've had a look at the platform environment and have noticed that fundraise page is still 'panelized' are you aware of this ? not sure how far along this PR is..

@Saphyel
Copy link
Contributor Author

Saphyel commented Dec 7, 2016

@bimsonz we need to purge it from campaign and then create a remove path for rnd17 stuff (fundraise page, I think the menu is also a problem... )

I don't think at this point content should be a blocker.. the next year is going to be.

@gusliedke
Copy link
Contributor

@Saphyel I've replaced landing page twig. looks like everything is working fine. We've got cr_layout which contains some custom layouts. This is not useful anymore. Can we just remove it?

@Saphyel
Copy link
Contributor Author

Saphyel commented Dec 13, 2016

@gusliedke we can get rid of it, if we no longer use it

@gusliedke
Copy link
Contributor

@Saphyel ok check please if I haven't left anything behind

@Saphyel
Copy link
Contributor Author

Saphyel commented Dec 13, 2016

@gusliedke So I found some errors but after removing panels, panels_ipe, quick edits & contextual links looks like everything is fine

@Saphyel Saphyel added this to the 1.21.0 milestone Dec 13, 2016
@bimsonz bimsonz modified the milestones: 1.22.0, 1.21.0 Dec 13, 2016
@gusliedke
Copy link
Contributor

@Saphyel @bimsonz @pvhee are we all happy to merge this? FE looks fine.

@pvhee
Copy link
Contributor

pvhee commented Dec 15, 2016

Yep, after QA passes

@bimsonz
Copy link
Contributor

bimsonz commented Dec 15, 2016

@pvhee Has this been QA'd yet, i thought it had.. happy to merge it in and see how it holds up if it has

@pvhee
Copy link
Contributor

pvhee commented Dec 16, 2016

@bimsonz currently in QA as per https://jira.comicrelief.com/browse/PLAT-549

@pvhee
Copy link
Contributor

pvhee commented Dec 16, 2016

And merging! 💥

@pvhee pvhee merged commit 6193e09 into develop Dec 16, 2016
@pvhee pvhee deleted the PLAT-549_bye_panelizer branch December 16, 2016 10:48
@pvhee
Copy link
Contributor

pvhee commented Dec 16, 2016

@bimsonz can you take special care of checking nodes aren't panelized anywhere in RND17 when prepping the release?

@bimsonz bimsonz mentioned this pull request Dec 19, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants