Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-409: bulletpoints for wysiwyg #661

Merged
merged 18 commits into from
Nov 30, 2016

Conversation

AndyEPhipps
Copy link
Contributor

@AndyEPhipps AndyEPhipps added this to the 1.20.0 milestone Nov 28, 2016
@Saphyel Saphyel force-pushed the feature/PLAT-409_bulletpoints_for_wysiwyg branch from ffa7bc8 to 32327e3 Compare November 29, 2016 12:34
@AndyEPhipps
Copy link
Contributor Author

AndyEPhipps commented Nov 29, 2016

@bimsonz @Saphyel: please note we'll need to manually copy/update the following config in the RND profile from the campaign profile, as per the changes here

editor.editor.basic_html.yml
editor.editor.full_html.yml

@gusliedke
Copy link
Contributor

Sorry @AndyEPhipps just checking it. I'm a bit concern the user has to go through an extra step just to format a list. Can't we just target all ul li in all components, pages body and in ckeditor and style it?

@AndyEPhipps
Copy link
Contributor Author

AndyEPhipps commented Nov 30, 2016

@gusliedke - I couldn't find a way to properly target UL lists; there's no common wrapper we can use that won't break existing non-text UL elements (menus etc). In order to just do it in CSS, we'd need to create a huge selector of all bespoke 'body' wrappers, that we'd need to update styles every time we produce a new component. Doesn't seem like the right approach to me.

Given that it takes all of 3 seconds to add the style to the markup, and that lists are used rarely at best, I don't really see this as an issue?

@AndyEPhipps
Copy link
Contributor Author

Passed QA

@AndyEPhipps
Copy link
Contributor Author

@bimsonz went a more sane route, text format import no longer needed here

@bimsonz
Copy link
Contributor

bimsonz commented Nov 30, 2016

@AndyEPhipps do we want that massive css file committed or can we not get it to generate ? if we dont lets add to git ignore and remove from repo with git rm --cached

@AndyEPhipps
Copy link
Contributor Author

@bimsonz yeah, was saying the same to @gusliedke; the Bless css will always be recompiled during build so no point in committing em. Will do that now

@gusliedke gusliedke merged commit 0ac873c into develop Nov 30, 2016
@gusliedke gusliedke deleted the feature/PLAT-409_bulletpoints_for_wysiwyg branch November 30, 2016 17:19
@bimsonz bimsonz restored the feature/PLAT-409_bulletpoints_for_wysiwyg branch December 2, 2016 11:00
@Saphyel Saphyel mentioned this pull request Dec 5, 2016
@Saphyel Saphyel deleted the feature/PLAT-409_bulletpoints_for_wysiwyg branch December 13, 2016 14:09
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants