-
Notifications
You must be signed in to change notification settings - Fork 10
PLAT-409: bulletpoints for wysiwyg #661
PLAT-409: bulletpoints for wysiwyg #661
Conversation
ffa7bc8
to
32327e3
Compare
Sorry @AndyEPhipps just checking it. I'm a bit concern the user has to go through an extra step just to format a list. Can't we just target all ul li in all components, pages body and in ckeditor and style it? |
@gusliedke - I couldn't find a way to properly target UL lists; there's no common wrapper we can use that won't break existing non-text UL elements (menus etc). In order to just do it in CSS, we'd need to create a huge selector of all bespoke 'body' wrappers, that we'd need to update styles every time we produce a new component. Doesn't seem like the right approach to me. Given that it takes all of 3 seconds to add the style to the markup, and that lists are used rarely at best, I don't really see this as an issue? |
Passed QA |
…e/PLAT-409_bulletpoints_for_wysiwyg
…m:comicrelief/campaign into feature/PLAT-409_bulletpoints_for_wysiwyg
@bimsonz went a more sane route, text format import no longer needed here |
@AndyEPhipps do we want that massive css file committed or can we not get it to generate ? if we dont lets add to git ignore and remove from repo with git rm --cached |
@bimsonz yeah, was saying the same to @gusliedke; the Bless css will always be recompiled during build so no point in committing em. Will do that now |
https://jira.comicrelief.com/browse/PLAT-409