PLAT-481 card banners #665
Conversation
|
@bimsonz going to update page.html.twig |
|
@gusliedke I've added a region and outputted it in the page template already but feel free to change the surrounding markup |
|
Ok just updated region placement and markup. Should I try to replicate the banner in the ticket? |
|
@gusliedke you can once ive fixed platform.sh! |
|
getting back to this soon .. just need to update cards banner template |
|
@gusliedke thanks mate, its blocked until at least liv's back but be good to show her it fully looking good :) |
|
@gusliedke do you think you could demo this along with your approach to the admin side of things tomorrow with liv? just so me not being in this week doesnt block the progress! thanks |
|
Functionality is done with minor frontend. We haven't got the new look and feel yet so it can be another task (frontend banner). |
|
@bimsonz noticed this page breaking? any idea? http://pr-665-agwllsi-tx3mbsqmxtu74.eu.platform.sh/whats-going-on \cc @gusliedke |
|
@gusliedke maybe add in a new ticket in JIRA, tag Caroline and link back to this one too? Then we can put it in blocked while we release this ticket. We should also tell QA to test functionality only, not the responsiveness etc. |
|
@pvhee @gusliedke |
| @@ -28,6 +28,7 @@ ckeditor_stylesheets: | |||
| - css/styles.css | |||
|
|
|||
| regions: | |||
| banners: Banners | |||
There was a problem hiding this comment.
Will this region need declaring in the RND theme too? Can't remember what's inherited
| {% | ||
| set content_wrapper_class = [ | ||
| 'card-banner__content-wrapper', | ||
| no_image, |
| @@ -47,6 +47,7 @@ | |||
| {{ page.breadcrumb }} | |||
| {{ page.highlighted }} | |||
| {{ page.help }} | |||
| <section class="main-banner">{{ page.banners }}</section> | |||
There was a problem hiding this comment.
Again, I guess this'll need doing in RND too?
|
I deleted cr_layout removing panelizer |
|
It must be in develop.. I will create a ticket and fix it |
|
@gusliedke develop seems to be working fine though.. weird? http://develop-tx3mbsqmxtu74.eu.platform.sh/whats-going-on (this is up to date) |
|
We need to add region to RND as well. |
…o feature/PLAT-481_card_banners
|
passed QA |
AndyEPhipps
added
Code Reviewed
Status: Reviewed
and removed
Status: Needs Review
labels
Fixes https://jira.comicrelief.com/browse/PLAT-481