Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-641 Add bing option #669

Merged
merged 1 commit into from
Nov 30, 2016
Merged

PLAT-641 Add bing option #669

merged 1 commit into from
Nov 30, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Nov 30, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-641

Changes proposed in this pull request

  • Enable module
  • Add config

@@ -13,3 +13,4 @@ tags:
og_type: article
og_image: '[site:url]/profiles/cr/themes/custom/campaign_base/images/og/rnd-logo_open-graph_v2.jpg'
og_url: '[current-page:url:absolute]'
bing: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel has this work been done in campaign as well ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry ignore me...

@@ -53,6 +53,7 @@ dependencies:
- video_embed_wysiwyg
- filter
- metatag_open_graph
- metatag_verification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvhee when we discussed didn't we say not to enable in profile ? cant see it being too much of a problem? @Saphyel what config does this need? is it something profile thats going to be annoying for us later ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeaah not sure -- I think it's fine maybe to have it in the profile after all, as every site will need to do this..

@pvhee pvhee merged commit 484f25e into develop Nov 30, 2016
@pvhee pvhee deleted the PLAT-641_Metatag_bing branch November 30, 2016 16:55
@Saphyel Saphyel mentioned this pull request Dec 5, 2016
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants