PLAT-642 Update core #681
PLAT-642 Update core #681
Conversation
| @@ -9,7 +9,7 @@ | |||
| <property name="cs.dir" override="true" value="drupal/coder/coder_sniffer"/> | |||
| <property name="cs.standard" override="true" value="--standard=Drupal"/> | |||
| <property name="cs.ext" override="true" value="--extensions=php,module,inc,install,test,profile,theme"/> | |||
| <property name="db.querystring" override="true" value="mysql://root:@localhost/campaign"/> | |||
| <property name="db.querystring" override="true" value="mysql://root:root@mysql/campaign"/> | |||
There was a problem hiding this comment.
your local docker changes @Saphyel ?
There was a problem hiding this comment.
Yep, but I tested couple of times and deployment + travis + plat.sh should be ok with this change, they have their own config, and you guys override this bit too. So don't hurt anyone.
|
@Saphyel can you get QA to sanity test the platform.sh env just to make sure its looking alright ? |
|
@bimsonz I was waiting to be build in plat.sh for send the link. But look an easy update only affects core and on my local I didn't see anything wrong or errors (except the bless) |
|
@Saphyel cool.. the bless error is fixed.. have you updated develop ? |
|
I'm gonna delete the node_modules/ & run again grunt:dependencies to make sure that works Yep it works now |
|
@bimsonz qa said that looks amazing! |
Fixes https://jira.comicrelief.com/browse/PLAT-642