Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-12 Implement News article #7

Merged
merged 26 commits into from
Feb 11, 2016
Merged

PLAT-12 Implement News article #7

merged 26 commits into from
Feb 11, 2016

Conversation

Saphyel
Copy link
Contributor

@Saphyel Saphyel commented Jan 27, 2016

Todo

  • Add News content type.
  • Add view with all news.
  • Add view with 3 related news.
  • Fix URL/pathauto
  • Build the final display for one new article
  • Generate default content and add as json to the a module called cr_default_content
  • Get rid of default article and make news_article the new article Call it article
  • Document the module with a README.md that lists the fields used, and do the same for the cr profile, similar to this
  • Move site generic fields to cr profile, keep article specific files in news feature
  • Include picture support for responsive images

vid: media
description: 'Media categories.'
hierarchy: 0
weight: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saphyel we'd need to package this differently, probably as features as using config_devel, look at how agov organizes for example agov_article. If we put everything in here as part of the profile, it'll be a mess pretty soon :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I move it, sorry I'll change it to the news custom module

@pvhee
Copy link
Contributor

pvhee commented Jan 28, 2016

@Saphyel generally would like to see how this looks like - can you deploy this to Pantheon (I can show you how to)

@Saphyel Saphyel changed the title PLAT-12 Add youtube module PLAT-12 Implement News article Feb 4, 2016
@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 5, 2016

I wanna propose a change/improvement here.

  • Actually the logic for realise if the content is a video or not is checking the "Type of news" and it's hard coded in the template. I think this should be in the view and should depend in the video link field.
  • The field Type of news is confusing, the main goal of this field is say: "this should be hide or expose as video or normal new" so maybe it's better rename it to: "Hide/Expose"

@pvhee
Copy link
Contributor

pvhee commented Feb 5, 2016

@Saphyel agreeing with these changes, pls proceed

@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 8, 2016

I wanna turn down the default_content module as @gusliedke suggest by 2 reasons:

  • You need to create the node 1st and then export it...
  • Images should be in sites/default/files in order to import them..

As alternative I'm gonna say: Devel generate or https://www.drupal.org/project/realistic_dummy_content

@pvhee
Copy link
Contributor

pvhee commented Feb 9, 2016

@Saphyel with default_content, you can export files in binary as well (you need file_entity module for this), and I don't think the flow of creating a node first then exporting it is a problem. Remember, default content is for us to start testing the site, not as a way to stage content from one environment to another. Happy to discuss further as well! \cc @gusliedke

@Saphyel Saphyel removed the Prototype label Feb 9, 2016
@Saphyel
Copy link
Contributor Author

Saphyel commented Feb 9, 2016

The "BE" here is done. The News articles has being "imported" as their actual status in sportrelief with default content, same images, videos, etc... (user is anonymous because is the way works webservices)

@pvhee
Copy link
Contributor

pvhee commented Feb 9, 2016

@Saphyel can you deploy this to Pantheon so we can review together?

@gusliedke gusliedke mentioned this pull request Feb 11, 2016
5 tasks
pvhee added a commit that referenced this pull request Feb 11, 2016
@pvhee pvhee merged commit 856b111 into develop Feb 11, 2016
@pvhee pvhee deleted the feature/PLAT-12_news branch February 11, 2016 14:25
@Saphyel Saphyel restored the feature/PLAT-12_news branch February 11, 2016 15:29
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants