Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

PLAT-65 Paragraph module #76

Merged
merged 71 commits into from
Mar 29, 2016
Merged

Conversation

bimsonz
Copy link
Contributor

@bimsonz bimsonz commented Mar 7, 2016

Fixes https://jira.comicrelief.com/browse/PLAT-65

Changes proposed in this pull request

  • DL and install paragraphs
  • Review module eligibility
  • Discuss all possible use cases
  • Involve design to see how we define paragraph types
  • Implement field on content types
  • Build pre defined paragraph types
  • Add to cr profile.info
  • Applied patch from https://www.drupal.org/node/2598138 but still not working exactly to export/import back content. Needs to be fixed

Deployment instructions

  • No manual actions required for deployment

@bimsonz bimsonz self-assigned this Mar 7, 2016
@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 7, 2016

Something to consider if we decide to go with this, does it add another level of complexity to search...

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 7, 2016

Basically this module provides a custom entity reference field that can be added to any content type.
The entities or "Paragraphs" that are referenced are just essentially field-able entities that we need to design. In our planning session we need to look into defining the type of content that would be referenced here and work with design on making this as flexible but secure as possible.

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 7, 2016

Looking at the following:

paragraphs_pack

paragraphs_pack

Checking eligibility, may not be worth it if we are going to be defining our own but also estimating effort for port to D8 in case we do

@pvhee
Copy link
Contributor

pvhee commented Mar 10, 2016

@gusliedke have a look at this PR and @bimsonz comments on this - let's aim to build a full prototype using paragraphs as well, then we can get @vdzimwasha involved to review the entire editorial experience

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 11, 2016

So im creating an alternative editorial experience for landing pages/ Content wall. Need to do the following:

  • Add field to content type
  • Create view mode for all paragraph types to be displayed in on fundraise pages
  • Add view mode select field to paragraph type "content wall"
  • Update class code with new logic
  • Export config so branch is build - able

@bimsonz bimsonz force-pushed the feature/PLAT-65_review_paragraph_module branch from d7dcad1 to 7d46299 Compare March 16, 2016 10:24
Given I am on "search?text=Lindsey"
Then I should see the link "Get to know Comic Relief"
#Given I am on "search?text=Lindsey"
#Then I should see the link "Get to know Comic Relief"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimsonz can we re-active the tests pls? this is a particular important test as it concerns landing pages are properly indexed \cc @Saphyel

@pvhee
Copy link
Contributor

pvhee commented Mar 26, 2016

@bimsonz generally looks fine, a couple of things to address and definitely would like the fundraise test to be operational again before moving to paragraphs

@bimsonz
Copy link
Contributor Author

bimsonz commented Mar 29, 2016

@pvhee this should be ready for merge now, can you review again quick please?

@pvhee
Copy link
Contributor

pvhee commented Mar 29, 2016

Looking cool, will merge in @bimsonz !

& .. welcome paragraphs :)

@pvhee pvhee merged commit 34565ee into develop Mar 29, 2016
@pvhee pvhee deleted the feature/PLAT-65_review_paragraph_module branch March 29, 2016 16:31
@pvhee pvhee mentioned this pull request Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants