-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Something to consider if we decide to go with this, does it add another level of complexity to search... |
Basically this module provides a custom entity reference field that can be added to any content type. |
Looking at the following: Checking eligibility, may not be worth it if we are going to be defining our own but also estimating effort for port to D8 in case we do |
@gusliedke have a look at this PR and @bimsonz comments on this - let's aim to build a full prototype using paragraphs as well, then we can get @vdzimwasha involved to review the entire editorial experience |
So im creating an alternative editorial experience for landing pages/ Content wall. Need to do the following:
|
d7dcad1
to
7d46299
Compare
Given I am on "search?text=Lindsey" | ||
Then I should see the link "Get to know Comic Relief" | ||
#Given I am on "search?text=Lindsey" | ||
#Then I should see the link "Get to know Comic Relief" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bimsonz generally looks fine, a couple of things to address and definitely would like the fundraise test to be operational again before moving to paragraphs |
…comicrelief/campaign into feature/PLAT-65_review_paragraph_module
@pvhee this should be ready for merge now, can you review again quick please? |
Looking cool, will merge in @bimsonz ! & .. welcome paragraphs :) |
Fixes https://jira.comicrelief.com/browse/PLAT-65
Changes proposed in this pull request
Deployment instructions