-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing fragments #65
Conversation
I think it's good if we can add a working fragment example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there @minhthong095! First of all, thanks for this PR.
Although I still think the proper approach to this enhancement would be to have middlewares, I was unable to fully work on it yet, so this PR would be the best solution for this for the time being.
However, we need to have tests (and examples) of how to use this new configuration, along with proper changes on documentation.
Could you do those changes? Ping me if you need any help!
Hi @comigor , I implemented test, examples and correct little code in |
Co-Authored-By: Igor Borges <igor@borges.dev>
…rtemis into sharing-fragments
Hi @comigor, just updated Could you take a look? |
Given GitHub token assignment for forks
Released as 2.2.0 |
Sharing fragment between queries and schemas.
This feature only enable if developer declare input
fragments_glob
like those configuration. If it isn't declared, Artemis will turn back to original.Will work well if it is declared within
queries_glob
defined on directly path.Good
Failed
Because in original source, even if i have 2 fragments with same name,
add_query_prefix: true
in 2 different files, different query (operation) name andbuild.yaml
config like 'Failed' above. Artemis will not generate too.So i came up with that solution.
In a huge project my team working on it's convenient to use sharing fragments.
Already considered this issue: #52