You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.
37: Ethereum HTLCs revert and return error message r=mergify[bot] a=bonomat
Resolves#8Resolves#30
We decided to go for `revert` with a reason (return data).
* the data returned by `revert` can be shown in etherscan
* a transaction failed due to `revert` will be shown as `failed` in metamask
* we live with the fact that a contract calling this HTLC can't recover from a failure within this contract
* return a string message. A client should be able to transform the returned bytes into text now :)
Note: I also updated solc to 0.5.16.
Version 0.6.x has breaking changes and a simple upgrade did not work.
--> Follow-up ticket:
comit-network/RFCs#135
Co-authored-by: Philipp Hoenisch <philipp@hoenisch.at>
Problem
It seems like both HTLCs for Ethereum (Ether and Erc20) do not print the keccak256 of the proposed messages:
Code claims:
blockchain-contracts/src/bin/calculate_offsets/ethereum/rfc003/templates/ether/contract.asm
Lines 69 to 75 in fe35482
However, I was not able to reproduce the same hash for neither of the 2:
Tested with web3js and http://emn178.github.io/online-tools/keccak_256.html
Proposal
()
which are meant to be included, i.e.keccak256("Refunded")
The text was updated successfully, but these errors were encountered: