Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

Test tryExecuteSirenAction #120

Closed
bonomat opened this issue Feb 18, 2020 · 0 comments · Fixed by #179
Closed

Test tryExecuteSirenAction #120

bonomat opened this issue Feb 18, 2020 · 0 comments · Fixed by #179
Assignees

Comments

@bonomat
Copy link
Member

bonomat commented Feb 18, 2020

Problem

Currently, the logic in the class Swap is not tested as much as we want. That means, if an error occurs somewhere in this logic, in the "best" case the client just crashes, in the worst case we would do something which could harm the user (e.g. accidentally overfund, or underfund, etc )

Goal

Be robust and maintain it by reviewing how to make the sdk robust to runtime failures.

Recommendation

Test that tryExecuteSirenAction actually times out.

Note: doLedgerAction is used in e2e test and has very little logic so there is no use testing it more.
Same for fieldValueResolver.

@D4nte D4nte changed the title Test Swap class Test tryExecuteSirenAction Mar 18, 2020
@D4nte D4nte added this to the Sprint 31 😢🚽 milestone Mar 24, 2020
@luckysori luckysori self-assigned this Mar 29, 2020
@bors bors bot closed this as completed in cef77e4 Mar 31, 2020
@bors bors bot closed this as completed in #179 Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants