This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Test tryExecuteSirenAction
#120
Milestone
tryExecuteSirenAction
#120
Problem
Currently, the logic in the class
Swap
is not tested as much as we want. That means, if an error occurs somewhere in this logic, in the "best" case the client just crashes, in the worst case we would do something which could harm the user (e.g. accidentally overfund, or underfund, etc )Goal
Be robust and maintain it by reviewing how to make the sdk robust to runtime failures.
Recommendation
Test that
tryExecuteSirenAction
actually times out.Note:
doLedgerAction
is used in e2e test and has very little logic so there is no use testing it more.Same for
fieldValueResolver
.The text was updated successfully, but these errors were encountered: