Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we really need the examples? #9

Closed
thomaseizinger opened this issue Jul 2, 2021 · 3 comments · Fixed by #15
Closed

Do we really need the examples? #9

thomaseizinger opened this issue Jul 2, 2021 · 3 comments · Fixed by #15

Comments

@thomaseizinger
Copy link
Contributor

I am not sure how much value they are adding over the examples that already exist in the rust-libp2p repository. I'd rather keep this repository simple.
@thomaseizinger thomaseizinger mentioned this issue Jul 2, 2021
Closed
@rishflab
Copy link
Member

rishflab commented Jul 4, 2021

In rust-libp2p the examples use identify which makes them incompatible with our rendezvous-server implementation. I made these examples so we have something we can use to test the rendezvous-server. I am not sure what @da-kami is using to test the rendezvous server atm. If they are not being used for that purpose and we do not intend to use them for e2e tests then we can remove them.

@thomaseizinger
Copy link
Contributor Author

In rust-libp2p the examples use identify which makes them incompatible with our rendezvous-server implementation.

Fair. Why don't we add an example that doesn't use identify then? Seems that would be more useful directly next to the implementation rather than here!

@rishflab
Copy link
Member

rishflab commented Jul 6, 2021

In rust-libp2p the examples use identify which makes them incompatible with our rendezvous-server implementation.

Fair. Why don't we add an example that doesn't use identify then? Seems that would be more useful directly next to the implementation rather than here!

yep that's probably the way to go

rishflab added a commit that referenced this issue Jul 8, 2021
@rishflab
Remove redundant examples
5cb0f4c 
An example where the register node specifies the external addr instead
of letting the Identify protocol determine it, have been included in the
 rust-libp2p lib.

 Closes #9.
@rishflab rishflab mentioned this issue Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove examples comit-network/rendezvous-server
2 participants
@thomaseizinger @rishflab