Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Load wallet in
monero-wallet-rpc
on demand if necessary
Previously, we relied on the wallet in the `monero-wallet-rpc` daemon to be loaded as we do on startup. As a consequence of this expectation, restarting `monero-wallet-rpc` to fix bugs like #652 resulted in the ASB no longer operating correctly. To fix this, we now load the wallet on-demand in case the daemon responds with the error code -13. Ideally, we would implement this behaviour generically using the proxy pattern on the `MoneroWalletRpc` trait. Unfortunately, when attempting to do so we uncover a limitation in the design of `jsonrpc_client`. This limitation is tracked in thomaseizinger/rust-jsonrpc-client#47. Once fixed, we can implement this logic in a more robust way that is not tied to the `check_tx_key` RPC call but applies to any RPC call automatically.
- Loading branch information