Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sys dependencies needed when running the CLI #208

Closed
da-kami opened this issue Feb 17, 2021 · 3 comments · Fixed by #218
Closed

No sys dependencies needed when running the CLI #208

da-kami opened this issue Feb 17, 2021 · 3 comments · Fixed by #218

Comments

@da-kami
Copy link
Member

da-kami commented Feb 17, 2021

When building the project on the raspberry I noticed that we currently have two dependencies, openssl and protobuf, which might also have to be available at runtime.

I temporarily solved this by installing the necessary libraries on the raspberry:

# install openssp dependencies
sudo apt install -y libssl-dev
# install protobuf dependency
sudo apt install -y protobuf-compiler

In order to allow easy use of the CLI we have to ensure that there are no external dependencies.

@D4nte
Copy link
Contributor

D4nte commented Feb 18, 2021

Theses dependencies are only needed to build the project. This is why they are postfixed with -dev and -compiler.
Did you try to uninstall them and run the binary?

@thomaseizinger
Copy link
Contributor

Theses dependencies are only needed to build the project.

Are you certain about this? -dev just means that we are installing the headers in addition to the shared library. Usually that is necessary because some project wants to link against this shared library which implies that the library still needs to be present at runtime.

@thomaseizinger
Copy link
Contributor

#218 takes care of the openssl dependency.

I couldn't find any mention of the protobuf compiler within the dependency tree. Are you sure that this one is required?

bors bot added a commit that referenced this issue Feb 23, 2021
218: Cleanup dependencies r=thomaseizinger a=thomaseizinger

Fixes #208.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
@bors bors bot closed this as completed in 2654879 Feb 23, 2021
abraham-nixon added a commit to abraham-nixon/xmr-btc-swap that referenced this issue Feb 15, 2022
218: Cleanup dependencies r=thomaseizinger a=thomaseizinger

Fixes comit-network/xmr-btc-swap#208.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants