Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history and balance command does not work with --json flag #766

Closed
binarybaron opened this issue Sep 9, 2021 · 7 comments · Fixed by #860
Closed

history and balance command does not work with --json flag #766

binarybaron opened this issue Sep 9, 2021 · 7 comments · Fixed by #860
Labels
bug Something isn't working

Comments

@binarybaron
Copy link
Collaborator

binarybaron commented Sep 9, 2021

./swap --testnet --json history and ./swap --testnet --json balance should output the swap history / balance in a JSON format instead of printing an ASCII table / text.

@rishflab
Copy link
Member

rishflab commented Sep 9, 2021

Thanks for pointing this out. Should be able to fix this.

Is this for the GUI you are working on?

@rishflab rishflab added the bug Something isn't working label Sep 9, 2021
@rishflab rishflab added this to Bug: Loss of Funds in Maintenance Sep 10, 2021
@rishflab rishflab moved this from Bug: Loss of Funds to Bug in Maintenance Sep 10, 2021
@binarybaron
Copy link
Collaborator Author

Thanks for pointing this out. Should be able to fix this.

Is this for the GUI you are working on?

Yes, it is. I haven't started working on the actual GUI yet, but I've been thinking about how best to process the logs, create child processes, which framework to use for the user interface, ...

@rishflab
Copy link
Member

Thanks for pointing this out. Should be able to fix this.
Is this for the GUI you are working on?

Yes, it is. I haven't started working on the actual GUI yet, but I've been thinking about how best to process the logs, create child processes, which framework to use for the user interface, ...

We are going to switch to sqlite as the DB (#133). One of the reasons we are making this switch is that sqlite libraries are available for most languages/platforms making it easier to build other applications on top of xmr-btc-swap. That should allow you to get a swap history with a SQL query. Does that work for you?

@binarybaron
Copy link
Collaborator Author

That would certainly work and make it much easier to be able to access the data.

@rishflab rishflab moved this from Bug to Up next in Maintenance Sep 13, 2021
@binarybaron binarybaron changed the title history command does not work with --json flag history and balance command does not work with --json flag Sep 14, 2021
@binarybaron
Copy link
Collaborator Author

Same goes for the balance command.

@xmrswapme
Copy link

Hello-

I just wanted to remark that we have successfully created a GUI for the swap CLI interface that interprets JSON and non-JSON output. It has not been fully tested as of yet, as we conducted around 10-12 swaps, 4 of which were successful and the others which gave us errors that we were able to handle appropriately.

In those swaps, we did not need to resume, cancel, or refund any of the swaps, so we don't know the JSON output for these commands. If anyone can provide us with more JSON output, it would benefit our mission in spreading the word of this wonderful implementation.

The GUI is a local webserver ran by Flask. It provides a database of market makers to choose from that is collated via user submission through our website

https://xmrswap.me

You can find out more and take a look at the screenshots at our repo:

https://github.com/xmrswapme/swapfe

It's very early testing and the more JSON output we get the more we can build around it.

@binarybaron
Copy link
Collaborator Author

#860

@bors bors bot closed this as completed in ea3316a Dec 22, 2021
abraham-nixon added a commit to abraham-nixon/xmr-btc-swap that referenced this issue Feb 15, 2022
860: Properly format output of commands `history`, `config`, `balance` and `list-sellers` using tracing r=rishflab a=binarybaron

Properly format output of commands `history`, `config`, `balance` and `list-sellers` using tracing

Closes comit-network/xmr-btc-swap#766

Co-authored-by: binarybaron <you@domain.com>
@binarybaron binarybaron removed this from Up next in Maintenance Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants