Change the bitcoin finality confirmation requirement from 2 to 1 block #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference : #796 |
|
If we do this, we should also reduce it to 1 for Line 66 in 1b95924 |
|
The 2 block requirement on the cli only affects the refund tx. On the ASB, the bitcoin finality confirmations can be set to 1 using the config file. This will get you the swap reduction time you desire. |
bors bot
added a commit
that referenced
this pull request
Dec 25, 2021
894: Reduce `bitcoin_finality_confirmations` from 2 to 1 r=da-kami a=binarybaron Reduces `bitcoin_finality_confirmations` from 2 to 1. This lowers the total time needed for a swap by an average of 10 minutes I'm aware that this has been proposed before (#800) and was rejected. > On the ASB, the bitcoin finality confirmations can be set to 1 using the config file. This will get you the swap reduction time you desire. I believe this is not correct. There is no way for ASB operators to configure the `bitcoin_finality_confirmations` setting. Only the `target_block` can be configured manually, but this is only used for estimating the fee rate when a btc transaction is published and not for deciding when it is safe to assume that the transaction is finalized. E.g the `config.toml` file of my (testate) asb ``` [data] dir = "/root/.local/share/xmr-btc-swap/asb/testnet" [network] listen = ["/ip4/0.0.0.0/tcp/9939", "/ip4/0.0.0.0/tcp/9940/ws"] external_addresses = ["/dnsaddr/unstoppableswap.net"] rendezvous_point = "/dnsaddr/discover.unstoppableswap.net/p2p/12D3KooWA6cnqJpVnreBVnoro8midDL9Lpzmg8oJPoAGi7YYaamE" [bitcoin] electrum_rpc_url = "ssl://electrum.blockstream.info:60002" target_block = 1 # My asb still waits for 2 confirmations on the btc lock tx network = "Testnet" [monero] wallet_rpc_url = "http://127.0.0.1:38083/json_rpc" network = "Stagenet" [tor] control_port = 9051 socks5_port = 9050 [maker] min_buy_btc = 0.0001 max_buy_btc = 0.1 ask_spread = 0.00 price_ticker_ws_url = "wss://ws.kraken.com" ``` Co-authored-by: binarybaron <you@domain.com>
bors bot
added a commit
that referenced
this pull request
Apr 14, 2022
894: Reduce `bitcoin_finality_confirmations` from 2 to 1 r=binarybaron a=binarybaron Reduces `bitcoin_finality_confirmations` from 2 to 1. This lowers the total time needed for a swap by an average of 10 minutes I'm aware that this has been proposed before (#800) and was rejected. > On the ASB, the bitcoin finality confirmations can be set to 1 using the config file. This will get you the swap reduction time you desire. I believe this is not correct. There is no way for ASB operators to configure the `bitcoin_finality_confirmations` setting. Only the `target_block` can be configured manually, but this is only used for estimating the fee rate when a btc transaction is published and not for deciding when it is safe to assume that the transaction is finalized. E.g the `config.toml` file of my (testate) asb ``` [data] dir = "/root/.local/share/xmr-btc-swap/asb/testnet" [network] listen = ["/ip4/0.0.0.0/tcp/9939", "/ip4/0.0.0.0/tcp/9940/ws"] external_addresses = ["/dnsaddr/unstoppableswap.net"] rendezvous_point = "/dnsaddr/discover.unstoppableswap.net/p2p/12D3KooWA6cnqJpVnreBVnoro8midDL9Lpzmg8oJPoAGi7YYaamE" [bitcoin] electrum_rpc_url = "ssl://electrum.blockstream.info:60002" target_block = 1 # My asb still waits for 2 confirmations on the btc lock tx network = "Testnet" [monero] wallet_rpc_url = "http://127.0.0.1:38083/json_rpc" network = "Stagenet" [tor] control_port = 9051 socks5_port = 9050 [maker] min_buy_btc = 0.0001 max_buy_btc = 0.1 ask_spread = 0.00 price_ticker_ws_url = "wss://ws.kraken.com" ``` Co-authored-by: binarybaron <you@domain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.