Changed the length for the columns [#1102]

* Expanded Credits.{Name, Role} to 255 bytes. * Expanded Cmics.{Publisher,Series} to 255 bytes. Also fixed some tech debt to allow several columns to accept UTF8 encoded values that are 3-bytes long.
comixed · Nov 20, 2021 · 28f121e · 28f121e
1 parent a282d34
commit 28f121e
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 5 deletions.
diff --git a/comixed-model/src/main/java/org/comixedproject/model/comicbooks/Comic.java b/comixed-model/src/main/java/org/comixedproject/model/comicbooks/Comic.java
@@ -184,7 +184,7 @@ public class Comic {
   @Setter
   private Date storeDate;
 
-  @Column(name = "Publisher", length = 128)
+  @Column(name = "Publisher", length = 255)
   @JsonProperty("publisher")
   @JsonView({
     View.ComicListView.class,
@@ -196,7 +196,7 @@ public class Comic {
   @Setter
   private String publisher;
 
-  @Column(name = "Series", length = 128)
+  @Column(name = "Series", length = 255)
   @JsonProperty("series")
   @JsonView({
     View.ComicListView.class,

diff --git a/comixed-model/src/main/java/org/comixedproject/model/comicbooks/Credit.java b/comixed-model/src/main/java/org/comixedproject/model/comicbooks/Credit.java
@@ -40,21 +40,21 @@ public class Credit {
   private Long id;
 
   @ManyToOne
-  @JoinColumn(name = "ComicId")
+  @JoinColumn(name = "ComicId", nullable = false, updatable = false)
   @JsonIgnore
   @Getter
   @NonNull
   private Comic comic;
 
-  @Column(name = "Name")
+  @Column(name = "Name", length = 255, nullable = false, updatable = false)
   @JsonProperty("name")
   @JsonView({View.ComicListView.class, View.AuditLogEntryDetail.class})
   @Getter
   @Setter
   @NonNull
   private String name;
 
-  @Column(name = "Role")
+  @Column(name = "Role", length = 255, nullable = false, updatable = false)
   @JsonProperty("role")
   @JsonView({View.ComicListView.class, View.AuditLogEntryDetail.class})
   @Getter

diff --git a/...xed-model/src/main/resources/db/migrations/0.11.0/012_1102_expand_credits_name_column.xml b/...xed-model/src/main/resources/db/migrations/0.11.0/012_1102_expand_credits_name_column.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+                   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                   xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.1.xsd">
+  <changeSet id="012_1102_expand_credits_name_column.xml"
+             author="mcpierce">
+
+    <modifyDataType tableName="Credits"
+                    columnName="Name"
+                    newDataType="varchar(255)"/>
+    <modifyDataType tableName="Credits"
+                    columnName="Role"
+                    newDataType="varchar(255)"/>
+    <modifyDataType tableName="Comics"
+                    columnName="Publisher"
+                    newDataType="varchar(255)"/>
+    <modifyDataType tableName="Comics"
+                    columnName="Series"
+                    newDataType="varchar(255)"/>
+
+    <!-- tech debt - MySQL encodings -->
+    <sql dbms="mysql">
+      ALTER TABLE ComicFileDescriptors MODIFY COLUMN Filename varchar (1024) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci NOT NULL;
+      ALTER TABLE Comics MODIFY COLUMN Filename varchar (1024) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci NOT NULL;
+      ALTER TABLE Comics MODIFY COLUMN Publisher varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE Comics MODIFY COLUMN Series varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE Comics MODIFY COLUMN Title longtext CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE Comics MODIFY COLUMN Notes longtext CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci;
+      ALTER TABLE Comics MODIFY COLUMN Description longtext CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci;
+      ALTER TABLE Credits MODIFY COLUMN Name varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE CharacterTags MODIFY COLUMN Name varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE LocationTags MODIFY COLUMN Name varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE StoryTags MODIFY COLUMN Name varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE TeamTags MODIFY COLUMN Name varchar (255) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL;
+      ALTER TABLE WebAuditLogEntries MODIFY COLUMN RequestContent longtext CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci;
+      ALTER TABLE WebAuditLogEntries MODIFY COLUMN ResponseContent longtext CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci;
+    </sql>
+
+  </changeSet>
+</databaseChangeLog>
diff --git a/comixed-model/src/main/resources/db/migrations/0.11.0/changelog-0.11.0.xml b/comixed-model/src/main/resources/db/migrations/0.11.0/changelog-0.11.0.xml
@@ -17,5 +17,6 @@
   <include file="/db/migrations/0.11.0/009_1059_removed_dates_from_last_read.xml"/>
   <include file="/db/migrations/0.11.0/010_516_add_page_renaming_rule_option.xml"/>
   <include file="/db/migrations/0.11.0/011_1072_add_purge_indicator_to_comics.xml"/>
+  <include file="/db/migrations/0.11.0/012_1102_expand_credits_name_column.xml"/>
 
 </databaseChangeLog>