Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ComicVineId to a number. #1046

Closed
mcpierce opened this issue Oct 17, 2021 · 0 comments · Fixed by #1048
Closed

Convert ComicVineId to a number. #1046

mcpierce opened this issue Oct 17, 2021 · 0 comments · Fixed by #1048
Assignees
@mcpierce
Labels
database Issues related to database management feature A new feature or enhancement to an exisiting feature
Milestone
0.11

Comments

@mcpierce
Copy link
Contributor

Currently, in the code, the ComicVineID for an entity is a string. But this value is actually always a number, so it should be converted to and treated as one.
@mcpierce mcpierce added database Issues related to database management feature A new feature or enhancement to an exisiting feature labels Oct 17, 2021
@mcpierce mcpierce added this to the 0.11 milestone Oct 17, 2021
@mcpierce mcpierce self-assigned this Oct 18, 2021
mcpierce added a commit to mcpierce/comixed that referenced this issue Oct 18, 2021
@mcpierce
Changed ComicVineId to be a number [comixed#1046]
73c6cd7
@mcpierce mcpierce linked a pull request Oct 18, 2021 that will close this issue
Changed ComicVineId to be a number [#1046] #1048
Merged
12 tasks
mcpierce added a commit to mcpierce/comixed that referenced this issue Oct 22, 2021
@mcpierce
Changed ComicVineId to be a number [comixed#1046]
b735bc3
mcpierce added a commit that referenced this issue Oct 22, 2021
@mcpierce
Changed ComicVineId to be a number [#1046]
5bf8feb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
database Issues related to database management feature A new feature or enhancement to an exisiting feature
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Changed ComicVineId to be a number [#1046] mcpierce/comixed
1 participant
@mcpierce