Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable setting the next/previous comic when retrieving a single comic. #105

Closed
mcpierce opened this issue Dec 23, 2019 · 1 comment
Closed

Disable setting the next/previous comic when retrieving a single comic. #105

mcpierce opened this issue Dec 23, 2019 · 1 comment
Assignees
@mcpierce
Labels
bug Something isn't working performance Issues relating to general application performance.
Milestone
0.5

Comments

@mcpierce
Copy link
Contributor

This code is causing the backend load an entire comic series just to set the next and previous comic reference. This is a very slow operation and needs to be disabled until it can be optimized.
@mcpierce mcpierce added bug Something isn't working performance Issues relating to general application performance. labels Dec 23, 2019
@mcpierce mcpierce added this to the 0.5 milestone Dec 23, 2019
@mcpierce mcpierce self-assigned this Jan 10, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 15, 2020
@mcpierce
[Issue comixed#105] Update the comic service to get the next/prev com…
effdad8 
…ic directly.
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 15, 2020
@mcpierce
[Issue comixed#105] Update the frontend to use the next/prev reference.
aa462ef 
 * Added logging to ComicAdaptor.
@mcpierce
Copy link
Contributor Author

I found an easier way to set the next and previous comics while getting the single issue using two queries, so I refactored the code to use that method.

jmcrfp pushed a commit that referenced this issue Jan 15, 2020
@mcpierce @jmcrfp
[Issue #105] Set the next/previous issue id when getting the details …
a520911 
…for a single comic. (#114)

* [Issue #105] Update the comic service to get the next/prev comic directly.

* [Issue #105] Update the frontend to use the next/prev reference.

 * Added logging to ComicAdaptor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working performance Issues relating to general application performance.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@mcpierce