Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record the number of files in an archive during the import process #12

Closed
mcpierce opened this issue Nov 21, 2019 · 0 comments
Closed

Record the number of files in an archive during the import process #12

mcpierce opened this issue Nov 21, 2019 · 0 comments
Assignees
@mcpierce
Labels
feature A new feature or enhancement to an exisiting feature importing Issues related to importing comics
Milestone
0.7

Comments

@mcpierce
Copy link
Contributor

As a user, I would like to know the number of files a comic archive contains - so I can easily identify files that were imported with less pages than are contained in the archive.

This doesn't need to be exposed in the front end (at this time), a simple int field in the comic table would suffice.

Ideally, the count would exclude xml files to reduce the frequency of false positives when comparing (for example) the number of hashed pages to the number of files in an archive.

Currently, the only way I can complete this type of check is by counting the hashed pages per comic, and then comparing the result to the page count in ComicRack.
@mcpierce mcpierce added enhancement A pull request containing a a new feature, refactoring, or security improvement.. importing Issues related to importing comics labels Nov 21, 2019
@mcpierce mcpierce added this to the 0.5 milestone Nov 21, 2019
@mcpierce mcpierce modified the milestones: 0.5, 0.6 Jan 10, 2020
@mcpierce mcpierce modified the milestones: 0.6, 0.7 Mar 25, 2020
@mcpierce mcpierce mentioned this issue Jun 10, 2020
Closed
@mcpierce mcpierce self-assigned this Jun 13, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 13, 2020
@mcpierce
Added a migration to create the comic_file_entries table [comixed#12]
4558007
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 13, 2020
@mcpierce
Added code to create and store the list of files in a comic [comixed#12]
a0103a9
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 13, 2020
@mcpierce
Added a migration to create the comic_file_entries table [comixed#12]
35bc4f9
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 13, 2020
@mcpierce
Added code to create and store the list of files in a comic [comixed#12]
7d4d3cc
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 13, 2020
@mcpierce
Added a migration to create the comic_file_entries table [comixed#12]
5ee0a06
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 13, 2020
@mcpierce
Added code to create and store the list of files in a comic [comixed#12]
9c2f652
mcpierce added a commit that referenced this issue Jun 13, 2020
@mcpierce
Added a migration to create the comic_file_entries table [#12]
e367644
mcpierce added a commit that referenced this issue Jun 13, 2020
@mcpierce
Added code to create and store the list of files in a comic [#12]
0d881c1
@mcpierce mcpierce added feature A new feature or enhancement to an exisiting feature and removed enhancement A pull request containing a a new feature, refactoring, or security improvement.. labels Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
feature A new feature or enhancement to an exisiting feature importing Issues related to importing comics
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
1 participant
@mcpierce