Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When scraping an comic with an issue number of 0, no data is retrieved #130

Closed
mcpierce opened this issue Jan 18, 2020 · 2 comments
Closed

When scraping an comic with an issue number of 0, no data is retrieved #130

mcpierce opened this issue Jan 18, 2020 · 2 comments
Assignees
@mcpierce
Labels
bug Something isn't working metadata Issues related to comic metadata
Milestone
0.5

Comments

@mcpierce
Copy link
Contributor

Describe the bug
When scraping a comic, and it's issue number is 0, then scraping results consistent come back empty even though the comic exists in ComicVine.

To Reproduce
Steps to reproduce the behavior:

  1. Begin scraping a comic.
  2. Enter "0" for the issue number.
  3. Fetch the volumes for the comic.
  4. Select the correct volume from the list returned.
  5. No comic is displayed.

Expected behavior

  1. The comic should be displayed since it exists.

Additional context
The scraping URL generated is missing the issue number:

http://comicvine.gamespot.com/api/issues/?api_key=[SNIPPED]&format=json&filter=volume:43019,issue_number:&field_list=cover_date,description,id,image,issue_number,name,store_date,volume
@mcpierce mcpierce added bug Something isn't working metadata Issues related to comic metadata labels Jan 18, 2020
@mcpierce mcpierce added this to the 0.5 milestone Jan 18, 2020
@mcpierce mcpierce self-assigned this Jan 18, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 18, 2020
@mcpierce
[Issue comixed#130] Allow for scraping a comic with an issue number o…
bd8a62b 
…f "0".
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 18, 2020
@mcpierce
[Issue comixed#130] Allow for an issue number of "0".
c8caa88
@bareheiny
Copy link

Will this happen for other non-standard issue numbers as well?

0.5, -1 etc.?

@mcpierce
Copy link
Contributor Author

mcpierce commented Jan 19, 2020 •
edited

@bareheiny No. It was code that removes leading "0" from issue numbers not stopping when it was a single "0". ;)

jmcrfp pushed a commit that referenced this issue Jan 20, 2020
@mcpierce @jmcrfp
[Issue #130] Allow a comic to have an issue number of "0" (#131)
e3e9a5e 
* [Issue #130] Allow for scraping a comic with an issue number of "0".

* [Issue #130] Allow for an issue number of "0".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working metadata Issues related to comic metadata
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@mcpierce @bareheiny