Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import from root of drive #178

Closed
SkaryMonk opened this issue Mar 13, 2020 · 6 comments
Closed

Unable to import from root of drive #178

SkaryMonk opened this issue Mar 13, 2020 · 6 comments
Labels
bug Something isn't working critical Critical issue importing Issues related to importing comics windows Issues specific to Windows
Milestone

Comments

@SkaryMonk
Copy link

I keep my comics in publisher folders in the root of my b: drive. Using the Admin > Import comics function, no comics are found if I use "b:" as the address, except for ones in the recycle bin. If I use "b:\215 INK" (or another publisher), the files are detected just fine.

I'm not entirely sure if the problem is that ComiXed can't add recursively from the root of a drive or if it's choking on something in the recycle bin. Here is what I think is the relevant output, but there's a bunch more Java stuff:

2020-03-13 12:08:07.866  INFO 18564 --- [nio-7171-exec-5] o.c.controller.file.FileController       : Getting all comic files: root=b:\
2020-03-13 12:08:07.867 DEBUG 18564 --- [nio-7171-exec-5] org.comixed.service.file.FileService     : Getting comics below root: b:\
2020-03-13 12:08:07.867 DEBUG 18564 --- [nio-7171-exec-5] org.comixed.service.file.FileService     : Loading files in directory: b:\
2020-03-13 12:08:07.868 DEBUG 18564 --- [nio-7171-exec-5] org.comixed.service.file.FileService     : Loading files in directory: b:\$RECYCLE.BIN
2020-03-13 12:08:07.868 DEBUG 18564 --- [nio-7171-exec-5] org.comixed.service.file.FileService     : Loading files in directory: b:\$RECYCLE.BIN\S-1-5-21-1296877425-985684126-905673246-1001
2020-03-13 12:08:07.870 DEBUG 18564 --- [nio-7171-exec-5] org.comixed.utils.ComicFileUtils         : Is desktop.ini a comic? No
2020-03-13 12:08:07.870 DEBUG 18564 --- [nio-7171-exec-5] org.comixed.service.file.FileService     : Loading files in directory: b:\$RECYCLE.BIN\S-1-5-21-1296877425-985684126-905673246-1003
2020-03-13 12:08:07.871 ERROR 18564 --- [nio-7171-exec-1] o.a.c.c.C.[.[.[/].[dispatcherServlet]    : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Admin > Import Comics'
  2. Enter 'b:' as path (and have comics there)
  3. Click "Find comics"
  4. Notice the 0 comics found

Expected behavior
All comics in all folders should be found.

Desktop (please complete the following information):

  • ComiXed version 0.6.0-0
  • OS: Windows 10
  • Browser name: Firefox
  • Browser version 73.0

ComiXed Build Detail
Source Branch | develop
Build Hostname | Pickled-Punk
Built On | Mar 2, 2020, 8:36:32 AM
Version | 0.6.0-0
Commit Hash | 9de3f4f
Committer Name | Darryl L. Pierce (mcpierce@gmail.com)
Time Of Last Commit | Mar 2, 2020, 12:21:34 AM
Commit Message | Squashed commit of the following:
Built From Uncommitted Code? | false
Remote Origin | https://github.com/comixed/comixed.git

@mcpierce
Copy link
Contributor

mcpierce commented Mar 13, 2020

@SkaryMonk CX handles searching recursively for comics in a directory tree, starting from the directory provided.

B: (without the backslash) doesn't point to the root of the drive, however. Instead it points to the current subdirectory being accessed on that drive by Windows. And in this case it appears to be the Recycle Bin directory on your system.

B:\ (with the backslash) is the root drive, and will tell CX to scan the entire drive for comic files. If you enter that then CX should find everything on the B: drive.

@SkaryMonk
Copy link
Author

Sorry, I mistyped, I think, and I should definitely mentioned that I've tried both options, and they both give the same result: "Failed to find any files".

If I enter "b:\" (with quotes), it says "Found 0 comics files", but that might be completely unrelated.

@mcpierce
Copy link
Contributor

@SkaryMonk Don't add the double quotes. Try B:/ instead.

@SkaryMonk
Copy link
Author

B:/ (both upper and lower case) yields the same result: "Failed to find any files".

Forward slashes does work when I specify a publisher folder, though (e.g. B:/215 INK/).

@mcpierce
Copy link
Contributor

@SkaryMonk Had a chance to start looking at this issue on a Windows machine.

It's always dying with a NullPointerException inside the Recycle Bin directory. There's at least one entry (on my system it's a file named "c:$Recycle.Bin\S-1-5-18" that is a directory according to Java but which returns null when retrieving the list of files in it. So I think I have a solution to fix this and will push an update for it shortly. If you could verify it (it'll be v0.5.2-1) solves the problem, please close this ticket.

@mcpierce mcpierce added bug Something isn't working critical Critical issue windows Issues specific to Windows labels Mar 14, 2020
@mcpierce mcpierce added this to the 0.5.2 milestone Mar 14, 2020
@mcpierce mcpierce added the importing Issues related to importing comics label Mar 14, 2020
@SkaryMonk
Copy link
Author

Confirmed solved! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Critical issue importing Issues related to importing comics windows Issues specific to Windows
Projects
None yet
Development

No branches or pull requests

2 participants