Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comics can be marked as read from the details > overview tab. #19

Closed
mcpierce opened this issue Nov 21, 2019 · 4 comments
Closed

Comics can be marked as read from the details > overview tab. #19

mcpierce opened this issue Nov 21, 2019 · 4 comments
Assignees
Labels
feature A new feature or enhancement to an exisiting feature library Issues related to loading, display or working with the library of comics
Milestone

Comments

@mcpierce
Copy link
Contributor

As a comic reader, I'd like to know when I've already read a comic.

Acceptance Criteria

  1. If a comic has not been previously read by the user, then no styling changes are shown.
  2. In the comic list view, if a comic has been read by the user, then the comic's row is styled differently.
  3. In the comic detail view, an indicator shows the comic has already been read.
@mcpierce mcpierce added enhancement A pull request containing a a new feature, refactoring, or security improvement.. library Issues related to loading, display or working with the library of comics labels Nov 21, 2019
@mcpierce mcpierce added this to the 0.6 milestone Nov 21, 2019
@bareheiny
Copy link

Question on this: as CX does not have a native reader, how would the read status be recorded?

@mcpierce
Copy link
Contributor Author

Ultimate CX will let readers call a REST API to mark a comic as read for a user. Also, the OPDS interface will ultimately let users filter the comics listed by their read state.

@mcpierce mcpierce modified the milestones: 0.6, 0.7 Mar 25, 2020
@bareheiny
Copy link

Any chance we could get a tickbox or something in the Overview page?

At the moment, the only way I can flag a comic as being read is by inserting a date read via SQL.

As Windows doesn't have any OPDS readers (that I've been able to find), and most existing readers likely won't be updated to make use of rest apis, the web interface may be the only way to mark comics as have been read.

@mcpierce
Copy link
Contributor Author

mcpierce commented Jun 2, 2020

@bareheiny Sure thing, we can add something to the overview tab to let you mark a comic as read.

@mcpierce mcpierce changed the title Read comics show an indicator marking them as read Comics can be marked as read from the details > overview tab. Jun 2, 2020
@mcpierce mcpierce self-assigned this Jun 15, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 20, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 20, 2020
@mcpierce mcpierce added feature A new feature or enhancement to an exisiting feature and removed enhancement A pull request containing a a new feature, refactoring, or security improvement.. labels Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or enhancement to an exisiting feature library Issues related to loading, display or working with the library of comics
Projects
None yet
Development

No branches or pull requests

2 participants