Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scraping comic with a "/" in the title fails. #208

Closed
bareheiny opened this issue Mar 29, 2020 · 4 comments
Closed

Scraping comic with a "/" in the title fails. #208

bareheiny opened this issue Mar 29, 2020 · 4 comments
Assignees
@mcpierce
Labels
bug Something isn't working metadata Issues related to comic metadata
Milestone
0.6

Comments

@bareheiny
Copy link

Attempting to scrape "Batman/Planetary: Deluxe Edition" causes a "Failed to get volumes for this comic." toaster to pop up.

Removing the "/" prior to scraping results in the correct issue being returned by the scraper.
@mcpierce mcpierce added the metadata Issues related to comic metadata label Mar 29, 2020
@mcpierce mcpierce added this to the 0.6 milestone Mar 29, 2020
@mcpierce mcpierce added the bug Something isn't working label Mar 29, 2020
@mcpierce
Copy link
Contributor

Effective we just need to encode or filter out characters like that when scraping a comic.

@mcpierce mcpierce self-assigned this May 8, 2020
@mcpierce
Copy link
Contributor

mcpierce commented May 8, 2020

@bareheiny This is suffering from the same problem that #219; i.e., the "/" in the series name is affecting the URL for the request.

mcpierce added a commit to mcpierce/comixed that referenced this issue May 8, 2020
@mcpierce
[Issue comixed#208] Move the series name to the request body.
cc0d628
mcpierce added a commit to mcpierce/comixed that referenced this issue May 8, 2020
@mcpierce
[Issue comixed#208] Changed the scraping API URL for getting volumes.
fa3d87c
mcpierce added a commit to mcpierce/comixed that referenced this issue May 8, 2020
@mcpierce
[Issue comixed#208] Correct the fields returned when scraping an issue.
3649e78
mcpierce added a commit to mcpierce/comixed that referenced this issue May 8, 2020
@mcpierce
[Issue comixed#208] Only retrieve the publisher's small logo.
9ad3ca0
mcpierce added a commit that referenced this issue May 9, 2020
@mcpierce
[Issue #208] Move the series name to the request body.
3859fac
mcpierce added a commit that referenced this issue May 9, 2020
@mcpierce
[Issue #208] Changed the scraping API URL for getting volumes.
efd4b3e
mcpierce added a commit that referenced this issue May 9, 2020
@mcpierce
[Issue #208] Correct the fields returned when scraping an issue.
3280b79
mcpierce added a commit that referenced this issue May 9, 2020
@mcpierce
[Issue #208] Only retrieve the publisher's small logo.
11653f9
@mcpierce
Copy link
Contributor

mcpierce commented May 9, 2020

@bareheiny This should now be fixed. Please checkout the latest build and, if this is no longer an issue, please close this ticket out.

@bareheiny
Copy link
Author

Looks good - the issue in question scraped successfully.

mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
[Issue #208] Move the series name to the request body.
afb13d9
mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
[Issue #208] Changed the scraping API URL for getting volumes.
4c4ab7d
mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
[Issue #208] Correct the fields returned when scraping an issue.
1bb4698
mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
[Issue #208] Only retrieve the publisher's small logo.
5e696dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working metadata Issues related to comic metadata
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@mcpierce @bareheiny