Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scraping - Issue count is one higher than expected in some cases. #211

Closed
bareheiny opened this issue Mar 29, 2020 · 4 comments
Closed

Scraping - Issue count is one higher than expected in some cases. #211

bareheiny opened this issue Mar 29, 2020 · 4 comments
Assignees
@mcpierce
Labels
bug Something isn't working metadata Issues related to comic metadata
Milestone
0.6

Comments

@bareheiny
Copy link

Seems to be related to TPBs.

Steps to replicate:

  1. Scrape a TPB (such as Black Widow: S.H.I.E.L.D.'s Most Wanted)
  2. When the results are returned, observe that the Issues value is 2
  3. Check the ComicVine page for the comic (https://comicvine.gamespot.com/black-widow-shields-most-wanted/4050-95202)
  4. Observe that the issue count is 1.
@bareheiny
Copy link
Author

Not just TPBs. The Immortal Hulk is showing 34 in the Issues field, despite issue 33 only coming out in the last week.

@mcpierce
Copy link
Contributor

I wonder if this is because CV has fixed an old issue with their APIs where they were underreporting the number of comics in a series? Our CV scraper code adds 1 based on what i read in Cory Banack's CV scraper for CR.

So if CV has fixed things, then we can remove this addition as well.

@mcpierce mcpierce added the metadata Issues related to comic metadata label Mar 30, 2020
@mcpierce mcpierce added this to the 0.6 milestone Mar 30, 2020
@mcpierce mcpierce self-assigned this Apr 25, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Apr 25, 2020
@mcpierce
[Issue comixed#211] Remove the addition to the issue count.
f8c0785
mcpierce added a commit that referenced this issue Apr 26, 2020
@mcpierce
[Issue #211] Remove the addition to the issue count.
9e99b00
@mcpierce
Copy link
Contributor

@bareheiny There's now a build with this fix available. Please check it when you have a chance and, if the issue is resolved, please close this ticket.

@mcpierce mcpierce added the bug Something isn't working label Apr 26, 2020
@bareheiny
Copy link
Author

Closing - issue counts now look correct (matching against Comic Vine).

mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
[Issue #211] Remove the addition to the issue count.
5a22201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working metadata Issues related to comic metadata
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@mcpierce @bareheiny