Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the volume when grouping comics. #231

Closed
mcpierce opened this issue Apr 3, 2020 · 4 comments
Closed

Include the volume when grouping comics. #231

mcpierce opened this issue Apr 3, 2020 · 4 comments
Assignees
Labels
library Issues related to loading, display or working with the library of comics
Milestone

Comments

@mcpierce
Copy link
Contributor

mcpierce commented Apr 3, 2020

Currently comics are managed on the frontend by series using only the name. This needs to include the volume as well, so that "Series 1 (v2000)" is differentiated from "Series 1 (v2015)".

@mcpierce mcpierce added the library Issues related to loading, display or working with the library of comics label Apr 3, 2020
@mcpierce mcpierce added this to the 0.6 milestone Apr 3, 2020
@bareheiny
Copy link

Keep in mind that there may be "duplicate" volumes for a series.

For example Gen 13 has a 1994 mini-series, followed by a 81 issue series starting in 1994...so they both would be Gen 13 (v1994).

@mcpierce
Copy link
Contributor Author

mcpierce commented Apr 4, 2020

Ooh, that's an unexpected wrinkle. How would we differentiate two different series that have the same publisher, series and volume values? That is, without relying on CV data.

@bareheiny
Copy link

bareheiny commented Apr 4, 2020

Ah...turns out that even CR just groups them together!

It hasn't caused me any problems because I use include the publication year and month in my file naming. Before I started doing that, I'm sure I accidentally overwrote an issue or two of 1999s Batman Beyond - which also has a short mini-series and a longer series starting in the same year.

@bareheiny
Copy link

Maybe it'll come down to alerting the user that there appears to be duplicate issues (bases on series, volume and issue number) for the a series and volume, and asking for them to flag the order somehow? Of course, doing that means the user would need to flag every comic in at least one of groups.

@mcpierce mcpierce self-assigned this Apr 5, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Apr 5, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Apr 5, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Apr 6, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Apr 6, 2020
@mcpierce mcpierce closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Issues related to loading, display or working with the library of comics
Projects
None yet
Development

No branches or pull requests

2 participants