Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using invalid credentials to log in returns a "Successfully logged out" toaster message. #270

Closed
bareheiny opened this issue May 15, 2020 · 5 comments
Closed

Using invalid credentials to log in returns a "Successfully logged out" toaster message. #270

bareheiny opened this issue May 15, 2020 · 5 comments
Labels
authentication Issues relating to authentication and authorization. bug Something isn't working

Comments

@bareheiny
Copy link

As per title.

I attempted to log into CX using an invalid user / password combination, and noted the "Successfully logged out" message was displayed, rather than the expected red (unsure of exact message) toaster.
@mcpierce mcpierce added authentication Issues relating to authentication and authorization. bug Something isn't working labels May 15, 2020
@mcpierce mcpierce added this to the No Milestone milestone May 15, 2020
@BRUCELLA2
Copy link
Contributor

I took a quick look at this bug.
It seems that when the username/password combination is invalid, the back returns a 401 error.
The 401 error is processed in hrx.interceptor and calls the startLogout method of the authenticationAdaptor.

I think we can call a new method (authenticationFailed) when error 401 is returned. This method can then dispatch the AuthLoginFailed action and we need to add the @effect for authentication that fails.

@mcpierce
Copy link
Contributor

@BRUCELLA2 I think you're spot on with that. Would you be able to provide a PR to do that?

@BRUCELLA2
Copy link
Contributor

@mcpierce i think i can provide a PR, yes.

BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 22, 2020
@BRUCELLA2
[Issue comixed#270] Fix wrong message when using invalid credentials …
4663613 
…to log.
BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 22, 2020
@BRUCELLA2
[Issue comixed#270] Fix wrong message when using invalid credentials …
e7f3c62 
…to log.
BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 24, 2020
@BRUCELLA2
[Issue comixed#270] Remove the hiding of the connection dialog and ad…
b59aebe 
…d a check if we are in the process of doing a login when the 401 error is sent.
BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 24, 2020
@BRUCELLA2
[Issue comixed#270] prettier clean up
1794e15
BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 24, 2020
@BRUCELLA2
[Issue comixed#270] Fix wrong message when using invalid credentials …
892b4b1 
…to log.
BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 24, 2020
@BRUCELLA2
[Issue comixed#270] Remove the hiding of the connection dialog and ad…
3c845e4 
…d a check if we are in the process of doing a login when the 401 error is sent.
BRUCELLA2 added a commit to BRUCELLA2/comixed that referenced this issue May 24, 2020
@BRUCELLA2
[Issue comixed#270] prettier clean up
6d83602
mcpierce pushed a commit that referenced this issue May 24, 2020
@BRUCELLA2 @mcpierce
[Issue #270] Fix wrong message when using invalid credentials to log.
2f9792e
mcpierce pushed a commit that referenced this issue May 24, 2020
@BRUCELLA2 @mcpierce
[Issue #270] Remove the hiding of the connection dialog and add a che…
d6f426f 
…ck if we are in the process of doing a login when the 401 error is sent.
mcpierce pushed a commit that referenced this issue May 24, 2020
@BRUCELLA2 @mcpierce
[Issue #270] prettier clean up
02610b5
mcpierce pushed a commit that referenced this issue May 24, 2020
@BRUCELLA2 @mcpierce
[Issue #270] prettier clean up
c543fe0
@mcpierce
Copy link
Contributor

@bareheiny A fix was provided by @BRUCELLA2 -- can you verify on the next build that this bug is fixed and close the ticket? Thanks.

@bareheiny
Copy link
Author

Looks good, closing.

mcpierce pushed a commit that referenced this issue Jun 22, 2020
@BRUCELLA2 @mcpierce
[Issue #270] Fix wrong message when using invalid credentials to log.
e087c82
mcpierce pushed a commit that referenced this issue Jun 22, 2020
@BRUCELLA2 @mcpierce
[Issue #270] Remove the hiding of the connection dialog and add a che…
dd6cc2c 
…ck if we are in the process of doing a login when the 401 error is sent.
mcpierce pushed a commit that referenced this issue Jun 22, 2020
@BRUCELLA2 @mcpierce
[Issue #270] prettier clean up
dce4a25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
authentication Issues relating to authentication and authorization. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcpierce @bareheiny @BRUCELLA2