Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin / Users page not showing correct label text #307

Closed
bareheiny opened this issue Jun 6, 2020 · 4 comments
Closed

Admin / Users page not showing correct label text #307

bareheiny opened this issue Jun 6, 2020 · 4 comments
Assignees
@mcpierce
Labels
bug Something isn't working translations Issues related to internationalization and localization.
Milestone
0.6

Comments

@bareheiny
Copy link

For example the new user button is showing "ADMIN.USER-EDITOR.LABEL.NEW-USER".

Account preferences (Details) menu is doing the same thing.
@mcpierce mcpierce changed the title Admin / Users page not showing correct label text (0.6.0-0.rc6 Admin / Users page not showing correct label text Jun 6, 2020
@mcpierce mcpierce self-assigned this Jun 6, 2020
@mcpierce mcpierce added bug Something isn't working translations Issues related to internationalization and localization. labels Jun 6, 2020
@mcpierce mcpierce added this to the 0.6 milestone Jun 6, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 6, 2020
@mcpierce
Added missing translations for the user admin page [comixed#307]
4670bd6
mcpierce added a commit that referenced this issue Jun 6, 2020
@mcpierce
Added missing translations for the user admin page [#307]
67ee88b
@mcpierce
Copy link
Contributor

mcpierce commented Jun 6, 2020

@bareheiny This is now fixed on develop and will show up in the next release candidate (rc7).

mcpierce added a commit that referenced this issue Jun 6, 2020
@mcpierce
Added missing translations for the user admin page [#307]
028569b
@bareheiny
Copy link
Author

Admin page looks good on rc7, but the Preferences items on Account \ Details shows the following:

comicvine.api-key |
import.directory |
library_display_cover_size | 136
library_display_rows | 50
library_display_same_height | 1
library_display_sort_field | sortableIssueNumber
library.consolidate.delete-physical-file

@mcpierce
Copy link
Contributor

@bareheiny That's expected -- the left hand side are the settings keys for all of your user preferences. They don't get translated.

@bareheiny
Copy link
Author

@mcpierce - all good then, closing this.

mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
Added missing translations for the user admin page [#307]
782e494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working translations Issues related to internationalization and localization.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@mcpierce @bareheiny