Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The comics import button doesn't seem to work correctly. #317

Closed
BRUCELLA2 opened this issue Jun 7, 2020 · 4 comments
Closed

The comics import button doesn't seem to work correctly. #317

BRUCELLA2 opened this issue Jun 7, 2020 · 4 comments
Labels
duplicate issue This issue or pull request already exists

Comments

@BRUCELLA2
Copy link
Contributor

Describe the bug
When I want to import comics files, I select the comics and then I click on the horizontal arrow button (see screenshot) to import the selected comics. Nothing happens. As a user I feel like there's a bug.

In order to make the import work, I have to click on the vertical arrow button next to the import button and select one of the two options (with or without metadata).

To Reproduce
Steps to reproduce the behavior:

  1. connect with admin account
  2. go in the import section
  3. select some comics files
  4. clic on the import button (horizontal arrow) => nothing happens.

Expected behavior
I think that when I click on the import button, I should either have a default behavior (import with metadata for example) or I should directly have the options menu displayed.

Screenshots
import the selected comics
import the selected comics 2

Desktop (please complete the following information):

  • ComiXed version : 0.7.0-0
  • OS: Windows 10 and Linux Mint 19.3 Tricia
  • Browser name : Brave Version 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit) and firefox 76.0 (64 bits)

ComiXed Build Detail

Source Branch | 87b8f68
Build Hostname | fv-az68
Built On | Jun 6, 2020, 5:29:15 PM
Version | 0.7.0-0
Commit Hash | 87b8f68
Committer Name | Darryl L. Pierce (mcpierce@gmail.com)
Time Of Last Commit | Jun 6, 2020, 5:03:17 PM
Commit Message | Changed the select reading list dialog to close after adding comics [#315]
Built From Uncommitted Code? | false
Remote Origin | https://github.com/comixed/comixed

Additional context

@bareheiny
Copy link

bareheiny commented Jun 7, 2020

Currently working as intended.

But I did ask for the number of actions (button presses) to begin an import be reduced in #152

@BRUCELLA2
Copy link
Contributor Author

Oups i don't see the #152 .

@mcpierce
Copy link
Contributor

mcpierce commented Jun 7, 2020

@BRUCELLA2 Given that we have #152 to streamline the import behavior, would you mind if we close this issue?

@mcpierce mcpierce added the duplicate issue This issue or pull request already exists label Jun 7, 2020
@BRUCELLA2
Copy link
Contributor Author

Yes, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate issue This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants