Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading list selection dialog does not close after comics are added. #315

Closed
mcpierce opened this issue Jun 6, 2020 · 0 comments
Closed

Reading list selection dialog does not close after comics are added. #315

mcpierce opened this issue Jun 6, 2020 · 0 comments
Assignees
@mcpierce
Labels
bug Something isn't working reading list Issues relating to reading lists
Milestone
0.6

Comments

@mcpierce
Copy link
Contributor

mcpierce commented Jun 6, 2020

Describe the bug
The dialog box should close after comics are successfully added to a list. But it isn't. Also, the box does not close when the X is clicked.

To Reproduce
Steps to reproduce the behavior:

  1. Select one or more comics.
  2. Select the "Add to list..." context menu item.
  3. Add the comics to a list.
  • The success toaster should popup.
  1. The dialog box remains opoen.

Expected behavior
The dialog box should be closed.

Screenshots
If applicable, add screenshots to help explain your problem.

** ComiXed Build Detail **
Source Branch develop
Build Hostname MacPierceBookPro.local
Built On Jun 6, 2020, 9:06:22 AM
Version 0.7.0-0
Commit Hash 83c2e7d
Committer Name Darryl L. Pierce (mcpierce@gmail.com)
Time Of Last Commit Jun 5, 2020, 4:58:44 PM
Commit Message Added the add comics to reading list dialog to the library page [#274]
Built From Uncommitted Code? true
Remote Origin git@github.com:comixed/comixed.git
@mcpierce mcpierce added bug Something isn't working reading list Issues relating to reading lists labels Jun 6, 2020
@mcpierce mcpierce added this to the 0.6 milestone Jun 6, 2020
@mcpierce mcpierce self-assigned this Jun 6, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 6, 2020
@mcpierce
Changed the select reading list dialog to close after adding comics [c…
a4ead05 
…omixed#315]
mcpierce added a commit that referenced this issue Jun 6, 2020
@mcpierce
Changed the select reading list dialog to close after adding comics [#…
87b8f68 
…315]
@mcpierce mcpierce closed this as completed Jun 6, 2020
@BRUCELLA2 BRUCELLA2 mentioned this issue Jun 7, 2020
Closed
This was referenced Jun 7, 2020
Closed
Closed
Closed
mcpierce added a commit that referenced this issue Jun 7, 2020
@mcpierce
Changed the select reading list dialog to close after adding comics [#…
79bca8b 
…315]
mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
Changed the select reading list dialog to close after adding comics [#…
5d0df4a 
…315]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working reading list Issues relating to reading lists
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@mcpierce