Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sorting of the "Start Year" and "Issues" column does not work on fetch volumes table #325

Closed
BRUCELLA2 opened this issue Jun 9, 2020 · 2 comments
Closed

The sorting of the "Start Year" and "Issues" column does not work on fetch volumes table #325

BRUCELLA2 opened this issue Jun 9, 2020 · 2 comments
Assignees
@mcpierce
Labels
bug Something isn't working metadata Issues related to comic metadata
Milestone
0.6

Comments

@BRUCELLA2
Copy link
Contributor

Describe the bug
When fetching the volumes, the sorting of the "Start Year" and "Issues" columns does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Connect with admin account
  2. Go to Comics section
  3. Select some comics
  4. Clic on Scrape selected Comics button
  5. Clic on Fetch volumes button
  6. Clic on "Start Year" or "Issues" to sort the table => don't work

Expected behavior
Sort table by "Start Year" or "Issues"

Screenshots
2020-06-09 - 10:26:00
2020-06-09 - 10:26:49

Desktop (please complete the following information):

  • ComiXed version : 0.6.0-0.rc7
  • OS: Windows 10 and Linux Mint 19.3 Tricia
  • Linux Browser name : Brave Version 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit) and firefox 77.0.1 (64 bits)
  • Windows Browser name : Brave Version 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit) and Chrome 83.0.4103.97 (Official Build) (64-bit)

** ComiXed Build Detail **
Source Branch c6993d1
Build Hostname fv-az129
Built On Jun 7, 2020, 12:20:01 AM
Version 0.6.0-0.rc7
Commit Hash c6993d1
Committer Name Darryl L. Pierce (mcpierce@gmail.com)
Time Of Last Commit Jun 7, 2020, 12:13:51 AM
Commit Message Added tags for v0.6.0-0.rc7 [#303]
Built From Uncommitted Code? true
Remote Origin https://github.com/comixed/comixed
@mcpierce mcpierce added bug Something isn't working metadata Issues related to comic metadata labels Jun 9, 2020
@mcpierce mcpierce added this to the 0.6 milestone Jun 9, 2020
@mcpierce mcpierce self-assigned this Jun 9, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jun 9, 2020
@mcpierce
Fixed sorting scraping volumes by start year and issue count [comixed…
e01a4c5 
…#325]
mcpierce added a commit that referenced this issue Jun 9, 2020
@mcpierce
Fixed sorting scraping volumes by start year and issue count [#325]
6049dc5
@mcpierce
Copy link
Contributor

mcpierce commented Jun 9, 2020

@BRUCELLA2 This is now fixed on develop and will be included in RC8 when it's released. Please verify it when you can and close this ticket if it's fixed.

mcpierce added a commit that referenced this issue Jun 9, 2020
@mcpierce
Fixed sorting scraping volumes by start year and issue count [#325]
95a543e
@BRUCELLA2
Copy link
Contributor Author

@mcpierce
For me it's ok. I close the issue.

mcpierce added a commit that referenced this issue Jun 22, 2020
@mcpierce
Fixed sorting scraping volumes by start year and issue count [#325]
097b611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working metadata Issues related to comic metadata
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@mcpierce @BRUCELLA2