Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'true/false' rather than '1/0' for boolean user preferences #387

Closed
mcpierce opened this issue Jul 1, 2020 · 0 comments · Fixed by #489
Closed

Use 'true/false' rather than '1/0' for boolean user preferences #387

mcpierce opened this issue Jul 1, 2020 · 0 comments · Fixed by #489
Assignees
@mcpierce
Labels
feature A new feature or enhancement to an exisiting feature users Issues related to the user subsystem.
Milestone
0.7

Comments

@mcpierce
Copy link
Contributor

mcpierce commented Jul 1, 2020

There are places in the code where the values '1' and '0' are used to specify boolean values for user preferences. These should instead user 'true' and 'false', respectively, to be more explicit.
@mcpierce mcpierce added enhancement A pull request containing a a new feature, refactoring, or security improvement.. users Issues related to the user subsystem. labels Jul 1, 2020
@mcpierce mcpierce added this to the 0.7 milestone Jul 1, 2020
@mcpierce mcpierce mentioned this issue Jul 1, 2020
Merged
@mcpierce mcpierce added feature A new feature or enhancement to an exisiting feature and removed enhancement A pull request containing a a new feature, refactoring, or security improvement.. labels Jul 6, 2020
@mcpierce mcpierce self-assigned this Aug 25, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Aug 25, 2020
@mcpierce
Changed user preferences to use true/false instead of 1/0 [comixed#387]
500bc75
mcpierce added a commit that referenced this issue Aug 28, 2020
@mcpierce
Changed user preferences to use true/false instead of 1/0 [#387]
f6de236
mcpierce added a commit that referenced this issue Aug 28, 2020
@mcpierce
Fixed a missed unit test [#387]
74ea6a6
@mcpierce mcpierce linked a pull request Aug 28, 2020 that will close this issue
Changed user preferences to use true/false instead of 1/0 [#387] #489
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
feature A new feature or enhancement to an exisiting feature users Issues related to the user subsystem.
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Changed user preferences to use true/false instead of 1/0 [#387] mcpierce/comixed
1 participant
@mcpierce