Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newly created reading list not showing in Library Contents pane without browser refresh. #401

Closed
bareheiny opened this issue Jul 9, 2020 · 2 comments
Closed

Newly created reading list not showing in Library Contents pane without browser refresh. #401

bareheiny opened this issue Jul 9, 2020 · 2 comments
Assignees
@mcpierce
Labels
bug Something isn't working critical Critical issue
Milestone
0.6

Comments

@bareheiny
Copy link

Note: typo here: NOTE: If this involves a pre-releae version of ComiXed and not a release, then please send an email to the mailing list rather than creating an issue here.

Describe the bug
When adding a new reading list, it is not shown in the Library Contents pane without forcing a browser refresh. There also seems to be a delay in it being shown in the "Add 1 Comic To A Reading List" pane, but that refreshes after a small amount of time.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to the Comics page
  2. Add a new reading list
  3. Expand the Library Contents pane
  4. Scroll to, and expand, reading lists - note that the newly created list does not appear

Expected behavior
A newly created reading list should be shown in the Library Contents pane shortly after being created.

Screenshots
List created:
Reading list

List not showing:
Missing reading list

Desktop (please complete the following information):

  • ComiXed version 0.6.1
  • OS: Windows 10 Pro, 64bit
  • Browser name Edge (chromium)
  • Browser version [Version 83.0.478.58 (Official build) (64-bit)

** ComiXed Build Detail **

Source Branch 6d46e00
Build Hostname fv-az51
Built On Jul 7, 2020, 5:10:04 PM
Version 0.6.1
Commit Hash 6d46e00
Committer Name Darryl L. Pierce (mcpierce@gmail.com)
Time Of Last Commit Jul 7, 2020, 3:11:47 PM
Commit Message Added a github_changelog_generator configuration file [#303]
Built From Uncommitted Code? true
Remote Origin https://github.com/comixed/comixed
@bareheiny bareheiny added the bug Something isn't working label Jul 9, 2020
@mcpierce mcpierce added the critical Critical issue label Jul 9, 2020
@mcpierce mcpierce added this to the 0.6.0-2 milestone Jul 9, 2020
@mcpierce mcpierce self-assigned this Jul 9, 2020
@mcpierce mcpierce modified the milestones: 0.6.1, 0.6.2, 0.6 Jul 9, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jul 9, 2020
@mcpierce
Fixed the View for fields in ReadingList [comixed#401]
7a7b391 
The View annotation was missing the LibraryUpdate view, so the fields
in a reading list were not being returned with the updates.
mcpierce added a commit to mcpierce/comixed that referenced this issue Jul 9, 2020
@mcpierce
Fixed when the frontend updates the reading list state [comixed#401]
1cb6d73 
Previously it was only doing the update when the comics had changed and
was not doing it when a reading list changed independent of comics.
mcpierce added a commit that referenced this issue Jul 9, 2020
@mcpierce
Fixed the View for fields in ReadingList [#401]
7281141 
The View annotation was missing the LibraryUpdate view, so the fields
in a reading list were not being returned with the updates.
mcpierce added a commit that referenced this issue Jul 9, 2020
@mcpierce
Fixed when the frontend updates the reading list state [#401]
94f1438 
Previously it was only doing the update when the comics had changed and
was not doing it when a reading list changed independent of comics.
@mcpierce
Copy link
Contributor

mcpierce commented Jul 9, 2020

@bareheiny A release is coming out shorting with this fix in it. Please verify it's fixed in 0.6.2 and close this ticket.

mcpierce added a commit that referenced this issue Jul 9, 2020
@mcpierce
Fixed the View for fields in ReadingList [#401]
5d13d6b 
The View annotation was missing the LibraryUpdate view, so the fields
in a reading list were not being returned with the updates.
mcpierce added a commit that referenced this issue Jul 9, 2020
@mcpierce
Fixed when the frontend updates the reading list state [#401]
8e95b59 
Previously it was only doing the update when the comics had changed and
was not doing it when a reading list changed independent of comics.
mcpierce added a commit that referenced this issue Jul 9, 2020
@mcpierce
Fixed the View for fields in ReadingList [#401]
b26e1c9 
The View annotation was missing the LibraryUpdate view, so the fields
in a reading list were not being returned with the updates.
mcpierce added a commit that referenced this issue Jul 9, 2020
@mcpierce
Fixed when the frontend updates the reading list state [#401]
33e55d5 
Previously it was only doing the update when the comics had changed and
was not doing it when a reading list changed independent of comics.
@bareheiny
Copy link
Author

Looks good, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working critical Critical issue
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@mcpierce @bareheiny