Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all of the list and details pages with a simpler model. #49

Closed
mcpierce opened this issue Nov 21, 2019 · 0 comments
Closed

Replace all of the list and details pages with a simpler model. #49

mcpierce opened this issue Nov 21, 2019 · 0 comments
Assignees
@mcpierce
Labels
feature A new feature or enhancement to an exisiting feature library Issues related to loading, display or working with the library of comics

Comments

@mcpierce
Copy link
Contributor

The code for all of those pages (publisher, series, character, team, location and story arc) is identical except for the observable they pull from.

To simplify the code, a single component for lists and one for details should be written. It should take as input a reference to an Observable to use for the source of data.
@mcpierce mcpierce added enhancement A pull request containing a a new feature, refactoring, or security improvement.. library Issues related to loading, display or working with the library of comics labels Nov 21, 2019
@mcpierce mcpierce added this to the No Milestone milestone Nov 21, 2019
@mcpierce mcpierce mentioned this issue Nov 23, 2019
Closed
@mcpierce mcpierce self-assigned this Nov 27, 2019
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Turn on debugging output for tests.
3bdf363
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Add the REST API for comic collections.
610f7f0
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Add the Collection state wiring.
8fabd98
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Add the CollectionDetailsPage component and tests.
2781b22
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Add the CollectionPage component and tests.
9f4f9b3
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Change the routing to use the new collection page.
ecbb4f0
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 1, 2019
@mcpierce
[Issue comixed#49] Remove the old collection components.
88955be
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 2, 2019
@mcpierce
[Issue comixed#49] Add the CollectionDetailsPage component and tests.
690a204
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 2, 2019
@mcpierce
[Issue comixed#49] Add the CollectionPage component and tests.
a11061e
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 2, 2019
@mcpierce
[Issue comixed#49] Change the routing to use the new collection page.
17f599b
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 2, 2019
@mcpierce
[Issue comixed#49] Remove the old collection components.
17bc29c
jmcrfp pushed a commit that referenced this issue Dec 3, 2019
@mcpierce @jmcrfp
[Issue #49] Reduce the number of components needed to view collection…
98c28c9 
…s. (#83)

* [Issue #49] Add the Collection state wiring.

* [Issue #49] Add the REST API for comic collections.

* [Issue #49] Turn on debugging output for tests.

* [Issue #49] Add the CollectionDetailsPage component and tests.

* [Issue #49] Add the CollectionPage component and tests.

* [Issue #49] Change the routing to use the new collection page.

* [Issue #49] Remove the old collection components.
@mcpierce mcpierce closed this as completed Dec 3, 2019
@mcpierce mcpierce added feature A new feature or enhancement to an exisiting feature and removed enhancement A pull request containing a a new feature, refactoring, or security improvement.. labels Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
feature A new feature or enhancement to an exisiting feature library Issues related to loading, display or working with the library of comics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcpierce