Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After importing comics, not all are being returned while being processed #9

Closed
mcpierce opened this issue Nov 21, 2019 · 1 comment
Closed

After importing comics, not all are being returned while being processed #9

mcpierce opened this issue Nov 21, 2019 · 1 comment
Assignees
@mcpierce
Labels
bug Something isn't working critical Critical issue library Issues related to loading, display or working with the library of comics
Milestone
0.5

Comments

@mcpierce
Copy link
Contributor

Describe the bug
When importing comics, not all are being returns while the comics are being processed.

To Reproduce
Steps to reproduce the behavior:

  1. Note the number of comics in the library (call it X).
  2. Start an import of some number (call it Y) of comics.
  3. During processing, the size of the library and the number of comics shown is not equal to X + Y.
  4. Scrolling through the library does not show X + Y comics.

Expected behavior
The number of comics should be equal to X + Y.

Screenshots
Screen Shot 2019-10-24 at 6 55 55 PM

Additional Notes
The total number of comics in the library should never be less than the number being processed.
@mcpierce mcpierce added bug Something isn't working critical Critical issue library Issues related to loading, display or working with the library of comics labels Nov 21, 2019
@mcpierce mcpierce added this to the 0.5 milestone Nov 21, 2019
@mcpierce
Copy link
Contributor Author

The issue appears to be related to including the last comic id in the query. We need to remove it from the query and instead retrieve all updates and then filter out items already returned.

@mcpierce mcpierce self-assigned this Dec 29, 2019
mcpierce added a commit to mcpierce/comixed that referenced this issue Dec 31, 2019
@mcpierce
[Issue comixed#9] Don't limit updates to comics over a specific ID in…
d2c3bb3 
… JQL.

Instead the filtering should be done after the results are retrieved.
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 7, 2020
@mcpierce
[Issue comixed#9] Get comics by last updated date is now inclusive of…
c5ab419 
… the timestamp.
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 7, 2020
@mcpierce
[Issue comixed#9] The library service removes comics already returned…
25745a1 
… in previous update.
jmcrfp pushed a commit that referenced this issue Jan 7, 2020
@mcpierce @jmcrfp
Feature/issue 9 (#110)
a877812 
* [Issue #9] Get comics by last updated date is now inclusive of the timestamp.

* [Issue #9] The library service removes comics already returned in previous update.
@mcpierce mcpierce closed this as completed Jan 8, 2020
mcpierce added a commit to mcpierce/comixed that referenced this issue Jan 9, 2020
@mcpierce
Feature/issue 9 (comixed#110)
2e4e953 
* [Issue comixed#9] Get comics by last updated date is now inclusive of the timestamp.

* [Issue comixed#9] The library service removes comics already returned in previous update.
@BRUCELLA2 BRUCELLA2 mentioned this issue Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcpierce mcpierce

Labels
bug Something isn't working critical Critical issue library Issues related to loading, display or working with the library of comics
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@mcpierce