Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a story system [#44] #1005

Merged
merged 1 commit into from Oct 7, 2021
Merged

Added a story system [#44] #1005

merged 1 commit into from Oct 7, 2021

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Oct 5, 2021

  • Added a model and server-side system for list and saving stories.
  • Added a state machine for managing stories.
  • Added a page to list all story names.
  • Added a page to list all stories for a name.
  • Changed comic tag table names.

Status

READY

Does this PR contain migrations?

YES

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Oct 5, 2021
@mcpierce mcpierce added this to the 0.11 milestone Oct 5, 2021
@mcpierce mcpierce force-pushed the feature/issue-44 branch 3 times, most recently from 8021d4e to 8fbe7f1 Compare October 6, 2021 12:09
BRUCELLA2
BRUCELLA2 reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@BRUCELLA2 BRUCELLA2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some feedback

comixed-model/src/main/resources/db/migrations/0.11.0/004_44_added_story_details.xml Show resolved Hide resolved
...d-webui/src/app/lists/pages/story-list-for-name-page/story-list-for-name-page.component.html Show resolved Hide resolved
comixed-webui/src/assets/i18n/en/reading-lists.json Outdated Show resolved Hide resolved
comixed-webui/src/assets/i18n/en/reading-lists.json Outdated Show resolved Hide resolved
comixed-webui/src/assets/i18n/de/reading-lists.json Outdated Show resolved Hide resolved
comixed-webui/src/assets/i18n/es/reading-lists.json Outdated Show resolved Hide resolved
@mcpierce
Added a story system [comixed#44]
69b3f5d 
 * Added a model and server-side system for list and saving stories.
 * Added a state machine for managing stories.
 * Added a page to list all story names.
 * Added a page to list all stories for a name.
 * Changed comic tag table names.
 * Changed translation file reading-lists.json => lists.json
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.6% 83.6% Coverage
0.0% 0.0% Duplication

@BRUCELLA2 BRUCELLA2 merged commit e796cc9 into comixed:master Oct 7, 2021
@mcpierce mcpierce deleted the feature/issue-44 branch October 7, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 BRUCELLA2 approved these changes

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcpierce @BRUCELLA2