Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues with the comic import process [#866] #1020

Merged
merged 1 commit into from Oct 12, 2021
Merged

Fixed issues with the comic import process [#866] #1020

merged 1 commit into from Oct 12, 2021

Conversation

mcpierce
Copy link
Contributor

  • Added exception logging to the comic insert writer.
  • Changed the comic notes column to being a clob.

Status

READY

Does this PR contain migrations?

YES

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Fixed issues with the comic import process [comixed#866]
1c93780 
 * Added exception logging to the comic insert writer.
 * Changed the comic notes column to being a clob.
@mcpierce mcpierce added the bugfix A pull request containing a fix for an issue. label Oct 11, 2021
@mcpierce mcpierce added this to the 0.11 milestone Oct 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit aecf677 into comixed:master Oct 12, 2021
@mcpierce mcpierce deleted the bugfix/feature-866 branch October 12, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 Awaiting requested review from BRUCELLA2

Assignees
No one assigned
Labels
bugfix A pull request containing a fix for an issue.
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcpierce