Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sorting comic covers [#1063] #1075

Merged
merged 1 commit into from Oct 30, 2021
Merged

Added sorting comic covers [#1063] #1075

merged 1 commit into from Oct 30, 2021

Conversation

mcpierce
Copy link
Contributor

  • Added a new persisted user preference: preference.sort-field

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Added sorting comic covers [comixed#1063]
7654061 
 * Added a new persisted user preference: preference.sort-field
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Oct 27, 2021
@mcpierce mcpierce added this to the 0.11 milestone Oct 27, 2021
@mcpierce mcpierce linked an issue Oct 27, 2021 that may be closed by this pull request
Comics can be sorted when viewed. #1063
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit a79a40b into comixed:master Oct 30, 2021
@mcpierce mcpierce deleted the feature/issue-1063 branch October 30, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 Awaiting requested review from BRUCELLA2

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Comics can be sorted when viewed.
1 participant
@mcpierce