Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added marking individual pages for deletion [#980] #1080

Merged
merged 1 commit into from Nov 4, 2021
Merged

Added marking individual pages for deletion [#980] #1080

merged 1 commit into from Nov 4, 2021

Conversation

mcpierce
Copy link
Contributor

  • Added a new feature to set the deleted state on pages.
  • Added REST APIs for marking and unmarking pages.

Also paid some technical debut by boosting the unit test converage
for PageController.

Status

READY

Does this PR contain migrations?

NO

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce
Added marking individual pages for deletion [comixed#980]
f5441ec 
 * Added a new feature to set the deleted state on pages.
 * Added REST APIs for marking and unmarking pages.

 Also paid some technical debut by boosting the unit test converage
 for PageController.
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Oct 30, 2021
@mcpierce mcpierce added this to the 0.11 milestone Oct 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2021 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.1% 97.1% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce linked an issue Oct 30, 2021 that may be closed by this pull request
Individual pages can be marked or unmarked for deletion. #980
Closed
@mcpierce mcpierce merged commit de31735 into comixed:master Nov 4, 2021
@mcpierce mcpierce deleted the feature/issue-980 branch November 4, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 Awaiting requested review from BRUCELLA2

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

Individual pages can be marked or unmarked for deletion.
1 participant
@mcpierce