Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #173] Fix loading the first image from a 7zip encoded archive. #174

Merged
merged 2 commits into from Mar 9, 2020
Merged

[Issue #173] Fix loading the first image from a 7zip encoded archive. #174

merged 2 commits into from Mar 9, 2020

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Mar 8, 2020

Status

READY

Migrations

NO

Description

Fix loading the first image for a 7zip-encoded archive.

@mcpierce mcpierce added bug Something isn't working critical Critical issue archive Issues relating to comic encoding labels Mar 8, 2020
@mcpierce mcpierce added this to the 0.5.1 milestone Mar 8, 2020
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit 2b04905 into comixed:develop Mar 9, 2020
@mcpierce mcpierce deleted the feature/issue-173 branch March 9, 2020 12:31
mcpierce added a commit that referenced this pull request Mar 9, 2020
@mcpierce
[Issue #173] Fix loading the first image from a 7zip encoded archive. (…
8c569ac 
…#174)

* [Issue #173] Replace old 7zip example comic with a new one.

* [Issue #173] Archive adaptors reset their reading position when finding the cover image.
mcpierce added a commit that referenced this pull request Mar 17, 2020
@mcpierce
Revert "[Issue #173] Fix loading the first image from a 7zip encoded …
e5d3885 
…archive. (#174)"

This reverts commit 2b04905.
mcpierce added a commit that referenced this pull request Mar 17, 2020
@mcpierce
Revert "[Issue #173] Fix loading the first image from a 7zip encoded …
dabff5e 
…archive. (#174)"

This reverts commit 2b04905.
mcpierce added a commit to mcpierce/comixed that referenced this pull request Mar 18, 2020
@mcpierce
[Issue comixed#173] Fix loading the first image from a 7zip encoded a…
91f2ae4 
…rchive. (comixed#174)
@mcpierce mcpierce mentioned this pull request Mar 18, 2020
Merged
mcpierce added a commit that referenced this pull request Mar 18, 2020
@mcpierce
[Issue #173] Fix loading the first image from a 7zip encoded archive. (…
69bc865 
…#174) (#189)
mcpierce added a commit that referenced this pull request Mar 18, 2020
@mcpierce
Revert "[Issue #173] Fix loading the first image from a 7zip encoded …
5c248c0 
…archive. (#174)"

This reverts commit 2b04905.
mcpierce added a commit that referenced this pull request Mar 18, 2020
@mcpierce
[Issue #173] Fix loading the first image from a 7zip encoded archive. (…
19715ca 
…#174) (#189)
mcpierce added a commit that referenced this pull request Apr 3, 2020
@mcpierce
[Issue #173] Fix loading the first image from a 7zip encoded archive. (…
840240e 
…#174) (#189)
@mcpierce mcpierce added bugfix A pull request containing a fix for an issue. and removed bug Something isn't working labels Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcrfp jmcrfp Awaiting requested review from jmcrfp

@PiDockMedia PiDockMedia Awaiting requested review from PiDockMedia

Assignees
No one assigned
Labels
archive Issues relating to comic encoding bugfix A pull request containing a fix for an issue. critical Critical issue
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcpierce