Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #73] Return an image placeholder when one isn't found on the backend #177

Merged
merged 2 commits into from Mar 14, 2020
Merged

[Issue #73] Return an image placeholder when one isn't found on the backend #177

merged 2 commits into from Mar 14, 2020

Conversation

mcpierce
Copy link
Contributor

Status

READY

Migrations

NO

Description

Returns the file missing.png when unable to load an image from a comic file.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Mar 11, 2020
@mcpierce mcpierce added this to the 0.6 milestone Mar 11, 2020
@mcpierce mcpierce requested a review from jmcrfp March 11, 2020 13:34
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

31.2% 31.2% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit 494b85f into comixed:develop Mar 14, 2020
mcpierce added a commit that referenced this pull request Mar 14, 2020
@mcpierce
[Issue #175] Return an image placeholder when one isn't found on the …
4489474 
…backend (#177)

* [Issue #175] Return the missing page image if a comic page could not be loaded.

* [Issue #175] Return the missing image placeholder when no cover is found during import.
@mcpierce mcpierce deleted the feature/issue-73 branch June 5, 2020 21:47
mcpierce added a commit that referenced this pull request Jun 22, 2020
@mcpierce
[Issue #175] Return an image placeholder when one isn't found on the …
a230e8f 
…backend (#177)

* [Issue #175] Return the missing page image if a comic page could not be loaded.

* [Issue #175] Return the missing image placeholder when no cover is found during import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcrfp jmcrfp Awaiting requested review from jmcrfp

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mcpierce