Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prompt the user for confirmation before logging out (#376) #377

Merged
merged 2 commits into from Jun 29, 2020

Conversation

BRUCELLA2
Copy link
Contributor

Status

READY

Migrations

NO

Description

Added prompt the user for confirmation before logging out

Added test unit for prompt user confirmation before logging out (comixed#376)
Copy link
Contributor

@mcpierce mcpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Just need to move the i18n entries and we can merge it.

comixed-frontend/src/assets/i18n/en/app.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit dc2b28a into comixed:develop Jun 29, 2020
jmcrfp pushed a commit to jmcrfp/comixed that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants