Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Worker with a thread pool manager #397

Merged
merged 5 commits into from Jul 8, 2020

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Jul 6, 2020

Status

READ

Migrations

NO

Description

Replaced Worker with TaskManager, which uses a ThreadPoolTaskExecutor to run the tasks in parallel. Removed the dependency on ConcurrentUnit as no longer needed.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Jul 6, 2020
@mcpierce mcpierce added this to the 0.7 milestone Jul 6, 2020
@mcpierce mcpierce requested review from BRUCELLA2 and jmcrfp July 6, 2020 19:32
@mcpierce mcpierce force-pushed the feature/issue-48 branch 4 times, most recently from 6fc616f to 60aa6e1 Compare July 7, 2020 01:47
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

82.0% 82.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@BRUCELLA2 BRUCELLA2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about thread pool managers but from what I've seen the pool request is approved.

@BRUCELLA2 BRUCELLA2 merged commit 26ee00f into comixed:develop Jul 8, 2020
@mcpierce mcpierce deleted the feature/issue-48 branch September 8, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants