Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed loading the cover when not in the image cache [#417] #450

Merged
merged 1 commit into from Jul 29, 2020
Merged

Fixed loading the cover when not in the image cache [#417] #450

merged 1 commit into from Jul 29, 2020

Conversation

mcpierce
Copy link
Contributor

@mcpierce mcpierce commented Jul 28, 2020 •
edited

Status

READY

Migrations

NO

Description

Updated ComicController to use ComicFileHandler to load a page's contents.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Jul 28, 2020
@mcpierce mcpierce added this to the 0.7 milestone Jul 28, 2020
@mcpierce mcpierce requested a review from BRUCELLA2 July 28, 2020 21:51
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@BRUCELLA2 BRUCELLA2 merged commit 8473493 into comixed:develop Jul 29, 2020
@mcpierce mcpierce deleted the feature/issue-417 branch July 29, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRUCELLA2 BRUCELLA2 BRUCELLA2 approved these changes

Assignees
No one assigned
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcpierce @BRUCELLA2