Add a ScrapingService to manage perform comic scraping #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpierce
added
the
enhancement
mcpierce
force-pushed
the
feature/issue-438
branch
from
0b53a6c
to
a2a7e5d
Compare
BRUCELLA2
suggested changes
Jul 31, 2020
...c/test/java/org/comixedproject/scrapers/comicvine/adaptors/ComicVineScrapingAdaptorTest.java
Outdated
Show resolved
Hide resolved
comixed-services/src/main/java/org/comixedproject/service/scraping/ScrapingService.java
Outdated
Show resolved
Hide resolved
comixed-services/src/main/java/org/comixedproject/service/scraping/ScrapingService.java
Outdated
Show resolved
Hide resolved
…xed#438] - comixed-rest-api will get the dependency through comixed-services.
- Renamed ComicVineScraperController => ScrapingController - Added the ScrapingService class. - ScrapingController delegates everything to ScrapingService. - Made ScrapingAdaptor more generic. - Added a new API to the ScrapingAdaptor for getting issue details.
mcpierce
force-pushed
the
feature/issue-438
branch
from
a2a7e5d
to
43e235d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
BRUCELLA2
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
Scraping is now initiated by a service that delegates to the ScrapingAdaptor. Caching is handled outside of the scraping adaptor so it can be focused solely on interacting with the comic data source.