Changed the REST API layer to initiate Tasks #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpierce
added
the
enhancement
mcpierce
force-pushed
the
feature/issue-432
branch
from
7ae3308
to
435e897
Compare
BRUCELLA2
suggested changes
Aug 3, 2020
comixed-repositories/src/main/java/org/comixedproject/repositories/comic/ComicRepository.java
Outdated
Show resolved
Hide resolved
comixed-services/src/test/java/org/comixedproject/service/comic/PageServiceTest.java
Outdated
Show resolved
Hide resolved
comixed-tasks/src/main/java/org/comixedproject/task/model/ConvertComicsWorkerTask.java
Show resolved
Hide resolved
comixed-tasks/src/main/java/org/comixedproject/task/model/DeleteComicsWorkerTask.java
Show resolved
Hide resolved
comixed-tasks/src/main/java/org/comixedproject/task/model/RescanComicsWorkerTask.java
Outdated
Show resolved
Hide resolved
comixed-tasks/src/main/java/org/comixedproject/task/model/RescanComicsWorkerTask.java
Show resolved
Hide resolved
|
There is some conficting files too. |
mcpierce
force-pushed
the
feature/issue-432
branch
from
435e897
to
c14d9d2
Compare
* comixed-services no longer depends on comixed-tass. * comixed-rest-api depends on comixed-tasks directly. * comixed-tasks depends on comixed-services directly.
mcpierce
force-pushed
the
feature/issue-432
branch
from
c14d9d2
to
740b02c
Compare
* All task class names end with "WorkerTask'. * All encoder class names include "WorkerTask".
mcpierce
force-pushed
the
feature/issue-432
branch
from
740b02c
to
f9648c1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
BRUCELLA2
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
Reworked the REST API layer to create tasks as needed. Added the ConvertComicsWorkerTask.