Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the ComicFormat feature with an auditable API [#465] #524

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

mcpierce
Copy link
Contributor

Status

READY

Migrations

NO

Description

Replaced the feature with an API that is logged. Broke out the frontend feature from the existing adaptor.

 * Added a new controller and service.
 * Made the API auditable.
 * Removed the old REST API.
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Oct 17, 2020
@mcpierce mcpierce added this to the 0.8 milestone Oct 17, 2020
 * Wrote a newer NgRx feature set for loading the formats.
 * Moved the comic format fixtures to the module fixtures file.
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mcpierce mcpierce merged commit cd58c8c into comixed:develop Oct 18, 2020
@mcpierce mcpierce deleted the feature/issue-465 branch October 18, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant