Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new comixed-web submodule to replace the UX [#328] #537

Merged
merged 14 commits into from
Nov 14, 2020

Conversation

mcpierce
Copy link
Contributor

Status

READY

Migrations

NO

Description

Created a new submodule, comixed-web, that provides an Angular app based on Angular Material for the user interface. Add the initial features to allow a user to login and logout, a confirmation dialog and an alert service, and a simple feature set based on NgRx.

@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Nov 12, 2020
@mcpierce mcpierce added this to the 0.8 milestone Nov 12, 2020
@mcpierce mcpierce changed the title Add the new comixed-web submodule to replace the UX [#328] Added the new comixed-web submodule to replace the UX [#328] Nov 12, 2020
Copy link
Contributor

@BRUCELLA2 BRUCELLA2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me, juste 2 questions / comments.

comixed-web/pom.xml Outdated Show resolved Hide resolved
 * Changed the run to single.
 * Added mocha as the default reporter.
 * Set minimum allowed coverage to 90% across the board.
 * Attaches the authentication token if one is currently held.
 * Any unmatched route is directed to this component.
 * Added the ability to load the current user.
 * Added the ability to log in a user.
 * Added the ability to logout the current user.
 * Refactored the REST APIs to be auditable.
 * Made the login REST API auditable.
 * Update the navigation bar when the user is logged in.
 * Monitor the current user from the application component.
 * Added routing to the login page.
 * Added logout confirmation.
 * Final code cleanup to pass tests.
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

52.6% 52.6% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A pull request containing a a new feature, refactoring, or security improvement..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants