-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the new comixed-web submodule to replace the UX [#328] #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpierce
added
the
enhancement
A pull request containing a a new feature, refactoring, or security improvement..
label
Nov 12, 2020
mcpierce
changed the title
Add the new comixed-web submodule to replace the UX [#328]
Added the new comixed-web submodule to replace the UX [#328]
Nov 12, 2020
mcpierce
force-pushed
the
feature/issue-328
branch
from
November 13, 2020 22:25
3e50648
to
0d832b6
Compare
BRUCELLA2
reviewed
Nov 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok for me, juste 2 questions / comments.
comixed-rest-api/src/test/java/org/comixedproject/controller/user/UserControllerTest.java
Outdated
Show resolved
Hide resolved
* Changed the run to single. * Added mocha as the default reporter. * Set minimum allowed coverage to 90% across the board.
* Attaches the authentication token if one is currently held.
* Any unmatched route is directed to this component.
* Added the ability to load the current user. * Added the ability to log in a user. * Added the ability to logout the current user. * Refactored the REST APIs to be auditable.
* Made the login REST API auditable. * Update the navigation bar when the user is logged in. * Monitor the current user from the application component. * Added routing to the login page. * Added logout confirmation. * Final code cleanup to pass tests.
mcpierce
force-pushed
the
feature/issue-328
branch
from
November 14, 2020 15:49
0d832b6
to
232cb2c
Compare
SonarCloud Quality Gate failed. 0 Bugs |
BRUCELLA2
approved these changes
Nov 14, 2020
This was referenced Dec 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
A pull request containing a a new feature, refactoring, or security improvement..
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
Created a new submodule, comixed-web, that provides an Angular app based on Angular Material for the user interface. Add the initial features to allow a user to login and logout, a confirmation dialog and an alert service, and a simple feature set based on NgRx.