Added STOMP messaging between the front and backends [#615] #641
Conversation
mcpierce
added
the
enhancement
mcpierce
force-pushed
the
feature/issue-615
branch
2 times, most recently
from
04701a3
to
d41136c
Compare
| */ | ||
| startSubscriptions(): void { | ||
| this.logger.debug('Starting session services'); | ||
| this.taskCountService.start(); |
There was a problem hiding this comment.
Why does sessionService.startSubscriptions call taskCountService.start? Is this some kind of test to see if it works well? If not, what is the purpose of this task counter normally used for import count service? ?
There was a problem hiding this comment.
The goal there is to divide up all of the various parts of the session that will use the messaging bus. Rather than having SessionService have some huge, monolithic method that subscribes to task counts, comic changes, reading list changes, etc., we'll code up each type of subscription as a separate service type (like TaskCountService) that can be started and stopped by SessionService.
That will also make it easier to test them since, like TaskCountService, they are isolated and testable by themselves.
| @@ -16,7 +16,7 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses> | |||
| */ | |||
|
|
|||
| import { createFeatureSelector } from '@ngrx/store'; | |||
| import { createFeatureSelector, createSelector } from '@ngrx/store'; | |||
There was a problem hiding this comment.
createSelector is never used
There was a problem hiding this comment.
I've removed it now.
mcpierce
force-pushed
the
feature/issue-615
branch
from
d41136c
to
0e6a35c
Compare
* Added the frontend messaging feature. * Added a queue for monitoring the number of active tasks. * Added a new feature to track server status.
mcpierce
force-pushed
the
feature/issue-615
branch
from
0e6a35c
to
7c01024
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Status
READY
Does this PR contain migrations?
NO
Before You Submit Your PR: